889635 - Usage information does not show in notifications

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of empty usage area when notifications are pulled down

Leo device, while using - happens on Unagi as well using the same build:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/01eacfdb4793
Gaia   0d5a9a7577f16b6a72a982148c6f509ee1714ea2
BuildID 20130702070214
Version 18.1

STR:
1. Pull down notifications
2. Observe no data shows
3. Go to usage app - observe that data shows

Screenshots attached

Comment 1

[Marcia Knous [:marcia]]

Attachment: Data showing in usage app

Comment 2

[Marcia Knous [:marcia]]

Attachment: Logcat

Comment 3

[Marcia Knous [:marcia]]

Nominating for blocking.

Comment 4

[Marcia Knous [:marcia]]

Broken:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/8d883cb49438
Gaia   6ed9316f397dfe09d8fa88506881d1a4e697643a
BuildID 20130629230208
Version 18.1

Works:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/8d883cb49438
Gaia   c9e9b09cb181fcd15d12af09f89ff87f553c06c7
BuildID 20130628070211
Version 18.1

Comment 5

[Marcia Knous [:marcia]]

In addition to this issue, there is also an issue in usage settings where you are not able to save any of your settings when selecting "Done." I assume it is part of the same issue since it is not seen in the "Works" build in Comment 4.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/10759

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 770658 [details]
https://github.com/mozilla-b2g/gaia/pull/10759

I prefer to keep the balance undefined as it is not mandatory. Anyway, this is already resolved in bug 888206.

Comment 9

[Leo]

This bug is due to the below(from v1train code)

[JavaScript Error: "TypeError: ConfigManager.configuration.balance is undefined" {file: "app://costcontrol.gaiamobile.org/js/widget.js" line: 109}]

So need to be uplifted to v1train.

Comment 10

[Zac C (:zac)]

Thanks Leo.

This isn't a duplicate because 888206 is resolved and this bug is still occurring.

Comment 11

[Salvador de la Puente González [:salva]]

Ok, I see. Indeed, the problem is the same but it was happening in two different places. Anyway, the solution is not adding a default value for balance object as it is valid to not have a balance section at all. The solution must be to not initialize the BalanceView when there is not balance section.

Comment 12

[cbarker]

This is covered by Test Case 5343

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=100&sortfield=created_on&sortdirection=desc&filter-id=5343&filter-productversion=92

Comment 13

[Allen Maxwell]

Test Case in Comment 12 is replaced by 8938, added to v1.1.0 daily smoketest

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=8938&filter-productversion=92

Comment 14

[Salvador de la Puente González [:salva]]

Attachment: Avoid startup error

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 771623 [details]
Avoid startup error

Damn it, we missed this in bug 888206, anyway the fix is pretty straight forward and works perfectly.

Thanks Salva.

Comment 16

[Salvador de la Puente González [:salva]]

Master: 9e3fc3bbbd07454644a911f1a60095e1d085ad07

Comment 17

[Teodosia Pop]

I can reproduce this again on v1-train on Unagi with today's build:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/f917f3fb17ab
Gaia   4d6b55ce05cfd94474946cbefc87fc1ecc930d21
BuildID 20130708230204
Version 18.0

Comment 18

[Teodosia Pop]

Attachment: screenshot 07/09

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Teodosia, this patch has not been backported yet to b2g18. It's only fixed on master. So lets see that we can get this backported. Setting the flags accordingly.

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 9e3fc3bbbd07454644a911f1a60095e1d085ad07 to:
v1-train: 878476f9e8b47c9398f847304d9387fa9fd23b92

Comment 21

[Teodosia Pop]

Verified fixed on v1-train.

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/b64372810dd7
Gaia   680c72ccbd2d5045e590a6ba08de2aac6af71953
BuildID 20130710230201
Version 18.0

Comment 22

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 878476f9e8b47c9398f847304d9387fa9fd23b92