889687 - [MP] Defect - nightly doesn't show default browser prompt if a release version has already been set as default

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Install/Update, defect, P1)

Description

[Marco Mucci [:MarcoM]]

(In reply to Samvedana (:Samvedana) from comment #8)
> User Agent:Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:25.0) Gecko/20130702
> Firefox/25.0
> Build ID:20130702110300
> 
> Tested on latest nightly from
> ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/07/2013-07-02-11-
> 03-00-mozilla-central/
> 
> When I installed new latest nightly Firefox, It didn't give me prompt to set
> default browser.I followed user story attached here.

Comment 1

[Jim Mathies [:jimm]]

WFM:

str:
1) set ie as the default
2) install firefox nightly
3) launch on desktop

result: I get the default prompt.

Comment 2

[Sam Foster [:sfoster] (he/him)]

I /think/ that this may reproduce if updating from an existing nightly, rather than a clean sheet. Not sure if that's the same bug, and can't confirm right now.

Comment 3

[Marco Mucci [:MarcoM]]

Hi Juan, can you test again to confirm this defect is happening.  Please see Comment #2 from Sam.

Comment 4

[juan becerra [:juanb]]

I tried the following:

From comment #2: Installing an older version, opting for No on the desktop Firefox prompt to make it my default browser, upgrading to the most recent version and seeing the prompt again. If I say yes, then I get the system prompt to make it my Metro browser.

I also tried the instructions in comment #1. These two work for me.

However, if I have a release version of Firefox installed and I have made that my default browser, and I then install the nightly, I don't get a prompt. I seem to have seen an existing bug for this, but I can't find it.

Comment 5

[Samvedana (:Samvedana)]

User Agent  :Mozilla/5.0 (Windows NT 6.2; WOW64; rv:25.0) Gecko/20130712 Firefox/25.0
Build ID: 20130712030203

Tested it on Latest nightly from ftp://ftp.mozilla.org/pub/firefox/nightly/2013/07/2013-07-12-03-02-03-mozilla-central/

When I installed new latest nightly Firefox, It didn't give me prompt to set
default browser.
I already had one nightly  installed before and set it as default browser.

Comment 6

[Samvedana (:Samvedana)]

Still seeing issue on yesterday's nightly.

Tested this on Windows 8.1 preview using  nightly from ftp://ftp.mozilla.org/pub/firefox/nightly/2013/07/2013-07-21-03-02-03-mozilla-central/

Firefox didn't ask me to make it default. I didn't have any version of Firefox installed.

Comment 7

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130809030203
Built from http://hg.mozilla.org/mozilla-central/rev/e33c2011643e

After installation of latest nightly, It didn't give prompt to make Firefox default. I had explorer as a default browser before installation of latest nightly. No other Firefox versions were installed.
I got one notification saying "You have new app to view webpage"

I don't know if this is required behavior.

Comment 8

[Jim Mathies [:jimm]]

(In reply to juan becerra [:juanb] from comment #4)
> However, if I have a release version of Firefox installed and I have made
> that my default browser, and I then install the nightly, I don't get a
> prompt. I seem to have seen an existing bug for this, but I can't find it.

Sorry I missed this part when I tested and posted to the email thread. Do we consider this a major issue? I doubt a lot of users will do this, but maybe I'm missing something..

Comment 9

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

So basically the bug is in confusion about the Vista defaults check.  It only checks for FirefoxURL and FirefoxHTML but doesn't check the actual app user model id hash nor the file path. 

This does all the normal checks that the options panel does, but skips over the html one.  And doesn't do the DDE checks also.

Also fixed a small bug with freeing the shell32 library, but I think the refcount was always > 1 so it didn't have any visible problems.

Comment 10

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/fx-team/rev/f05991fd97e3

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f05991fd97e3

Comment 12

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0

Works as expected on the latest Nightly (build ID: 20130929030202)

Nightly has shown the default browser prompt even if the release version was set as default.
Marking as verified.