889745 - Frequent Random Orange: TEST-UNEXPECTED-FAIL | test-plugin-outdated.js | test_outdated_plugin_notification (Notification value was not correct: 'null' == 'null')

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mark Banner (:standard8)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=24849952&tree=Thunderbird-Trunk

TEST-START | /Users/cltbld/talos-slave/test/build/mozmill/content-tabs/test-plugin-outdated.js | test_outdated_plugin_notification
Step Pass: {"function": "controller.click()"}
Step Pass: {"function": "controller.waitFor()"}
Test Failure: Notification value was not correct: 'null' == 'null'.
TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/mozmill/content-tabs/test-plugin-outdated.js | test-plugin-outdated.js::test_outdated_plugin_notification

Comment 1

[:aceman]

'null' == 'null' ?

This looks like something bug 880798 wants to fix. But that one is for xpcshell and this failure is in mozmill.
Changing platforms as the failure is also seen on Linux (on TB-trunk).

Comment 2

[:aceman]

Attachment: patch

Aryx, this would need a try run again, all systems (except Win), mozmill only.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Pushed to Thunderbird-Try: https://tbpl.mozilla.org/?tree=Thunderbird-Try&showall=1&rev=079ff8a50151

Comment 4

[:aceman]

Comment on attachment 771445 [details] [diff] [review]
patch

There are some build failures on opt targets but in the debug targets where the build succeeded it seems the test no longer fails.

(For the build failures, PR_USEC_PER_SEC is defined in msgCore.h which nsAutoSyncManager.cpp is not including.)

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 771445 [details] [diff] [review]
patch

Review of attachment 771445 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/cb74c0bcdd73

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 771445 [details] [diff] [review]
patch

[Triage Comment]
Another one bites the dust. So lets fix this on aurora as well :-)

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/3777b122c29d