Closed
Bug 889759
Opened 11 years ago
Closed 11 years ago
Design and implement a ContactsMerger module
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)
Tracking
(blocking-b2g:koi+)
People
(Reporter: jmcf, Assigned: jmcf)
References
Details
(Whiteboard: [u=commsapps-user c=contacts p=5])
Attachments
(1 file)
Given two Contacts C1 (local) and C2 (new) this module will be responsible for merging the two Contacts according to the rules defined by the acceptance criteria.
|
||
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0]
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0] → [u=commsapps-user c=contacts p=5]
|
|
Assignee | |
Comment 2•11 years ago
|
||
first version including unit tests
Attachment #777052 -
Flags: review?(francisco.jordano)
Attachment #777052 -
Flags: review?(crdlc)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 777052 [details]
Pointer to GH PR
Tried it and worked well, just leave a comment in github regarding the case of merging two fb linked contacts and how this can affect the data showed.
Thanks!
F.
Attachment #777052 -
Flags: review?(francisco.jordano) → review+
|
||
Comment 4•11 years ago
|
||
Comment on attachment 777052 [details]
Pointer to GH PR
Perfect for me although I would like to see some comment like
Step 1) Merging names
Step 2) Tel... bla bla
Because the function is very long and it is difficult to follow
Thanks a lot
Attachment #777052 -
Flags: review?(crdlc) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•