Closed
Bug 894865
Opened 11 years ago
Closed 11 years ago
Implement UI for active merge with suggestions from contact detail
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:koi+)
RESOLVED
FIXED
| blocking-b2g | koi+ |
People
(Reporter: crdlc, Assigned: crdlc)
References
Details
(Whiteboard: [u=commsapps-user c=contacts p=7])
Attachments
(1 file)
Implement UI for active merge with suggestions from contact detail
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Hardware: x86 → All
|
||
Updated•11 years ago
|
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=7]
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #778352 -
Flags: review?(jmcf)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Fixed unit tests and added a new one for the "Find duplicate contacts" button
|
|
Assignee | |
Comment 3•11 years ago
|
||
Added test suite for contacts.MatcherUI(contacts_matcher_ui.js) lib
|
|
Assignee | |
Updated•11 years ago
|
Attachment #778352 -
Attachment description: Patch v1 without unit testing → Patch v1 with unit testing
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 778352 [details]
Patch v1 with unit testing
pending feedback from Ismael concerning mark-up / CSS. Also there are some comments in Github to be implemented
Attachment #778352 -
Flags: review?(jmcf) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 778352 [details]
Patch v1 with unit testing
Hola Isma,
Could you review the CSS code for the duplicate contacts list?
Thanks a lot
Attachment #778352 -
Flags: feedback?(igonzaleznicolas)
|
||
Comment 6•11 years ago
|
||
Comment on attachment 778352 [details]
Patch v1 with unit testing
Everything looks more/less fine, just a couple of comments in GH
Thx!
Attachment #778352 -
Flags: feedback?(igonzaleznicolas) → feedback+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Done all comments so I gonna merge
|
|
Assignee | |
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
blocking-b2g: koi? → koi+
You need to log in
before you can comment on or make changes to this bug.
Description
•