890148 - Defect - "Find Bar" transition sluggish/slow

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P2)

Description

[Kamil Jozwiak [:kjozwiak]]

When selecting "Settings" -> "Find in Page" under the "Navigation App Bar", you'll notice that the "Find Bar" sliding in is very sluggish compared to the "Navigation App Bar". 

I'm not 100% sure if its the machine (using X1 Carbon) but the "Navigation App Bar" slides in and out very smoothly on the same machine compared to the "Find Bar". This makes it seem like the browser is lagging but really isn't.

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go to http://en.wikipedia.org/wiki/Main_Page
3) Slide in the "Navigation App Bar" (notice how smoothly it slides into view)
4) Select "Settings" -> "Find in Page" (notice how sluggish the transition appears)
5) Select the "X" on the "Find Bar" (notice how sluggish the transition appears)
6) Slide the "Navigation App Bar" in & out several times (notice how smoothly it slides into view)

Current Behavior:

- When sliding in the "Find Bar", it will appear very sluggish and slow compared the "Navigation App Bar"

Expected Behavior:

- Sliding the "Find Bar" in & out should be as smooth as sliding in the "Navigation App Bar"

Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-03-03-13-23-mozilla-central/

Comment 1

[Jim Mathies [:jimm]]

WFM, it doesn't seem slow. Yuan, are you happy with the display speed of the find bar?

Comment 2

[Asa Dotzler [:asa]]

This feels janky to me, not just slow. I hit ctrl+f to toggle on the find bar and it comes up in sort of three stages. First I see about 1/3rd of the bar, then a short pause, then about 3/4ths of it  animates up and onscreen and another short pause then the final bit shows.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Cant really investigate this while bug 896763 stands, which slides away (smoothly FWIW) the find bar before you can use it.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Streamline transitions when showing find appbar

Showing the findbar was triggering an animation of the browser's padding-bottom, which would definitely account for jankiness. This patch makes that a delayed, 0 second transition so padding-bottom gets set after the findbar has transitioned in. 

ctrl+l (show navbar) and ctrl+f (show find bar) and <escape> to hide them now look more equivalent to me.

Comment 5

[Sam Foster [:sfoster] (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bff7e921c95d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bff7e921c95d

Comment 7

[Manuela Muntean [Away]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130819030205

WFM
Tested on Windows 8 64bit using latest Nightly for iteration #12. Followed steps from comment 0, and everything works as expected: sliding the "Find Bar" in & out is as smooth as sliding in the "Navigation App Bar".

This also needs some device verification.

Comment 8

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130826074752
Built from http://hg.mozilla.org/mozilla-central/rev/14b1e8c2957e

WFM
Tested on windows 8 using latest nightly for iteration-12.

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #14 (Resolving Device Request from Iteration Document). Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-18-03-02-02-mozilla-central/

- Went through the original test case from comment #0 without any issues
- Ensured that sliding in the "Find Bar" via touch is a smooth experience
- Ensured that sliding in the "Find Bar" using "CTRL + F" is a smooth experience
- Ensured that all of the above test cases worked with filled view

Comment 10

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #15 without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-30-03-02-05-mozilla-central/

- Went through the original test case from comment #0 without any issues
- Ensured that sliding in the "Find Bar" via touch is a smooth experience
- Ensured that sliding in the "Find Bar" using "CTRL + F" is a smooth experience
- Ensured that dismissing the "Find Bar" using "ESC" is a smooth experience
- Ensured that all of the above test cases worked with filled view

Comment 11

[Kamil Jozwiak [:kjozwiak]]

Went through the following defect for iteration #20 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-12-22-03-02-04-mozilla-central/

- Went through the original test case from comment #0 without any issues
- Ensured that sliding in the Find App Bar using "Settings -> Find in page" under the Navigation App Bar was a smooth experience
- Ensured that sliding in the Find App Bar using "CTRL + F" was a smooth experience
- Ensured that closing the Find App Bar using "ESC" was a smooth experience
- Ensured that closing the Find App Bar using the "X" under the Find App Bar was a smooth experience
- Ensured that closing the Find App Bar with the OSK visible was a smooth experience
- Ensured that tapping on the website while the OSK was visible didn't dismiss the Find App Bar (made sure the entire experience was smooth)
- Ensured that all of the above test cases worked in filled view