890221 - [FM Radio] pressing Hardware Volume keys don't increase/decrease FM Radio volume

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect, P1)

Description

[Leo]

1. Title: Not able to change the volume of FM radio with volume hardware keys
2. Precondition: when in homescreen, reduce the volume to fully ZERO
3. Tester's Action: 
		1. Open FM app
		2. Play FM app
		3. Adjust the volume either increase/decrease.
		4. No sound heard(No change in volume's behaviour)
4. Detailed Symptom (ENG.): After setting the volume to zero on home screen, user cannot hear the sound while FM playing(irrespective of increasing or decreasing hardware volume keys)
5. Expected : User should be able to control volume 
6. Reproducibility: Y
1)Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 0a8b1d7c70c5ec2b48e52c2cd7e463f47fa0b9cb

Comment 1

[Marco Chen [:mchen]]

Thanks for the report. 
Randy or me will work on it next week.

Comment 2

[Seil Park]

I know it can`t set fm volume because flag"mFMChannelIsMuted" is true.
-------------------------------------------------------------------------
AudioManager::SetStreamVolumeIndex(int32_t aStream, int32_t aIndex) {
  ...
  if (aStream == AUDIO_STREAM_MUSIC && IsDeviceOn(AUDIO_DEVICE_OUT_FM) && !mFMChannelIsMuted) {
    AudioSystem::setStreamVolumeIndex(static_cast<audio_stream_type_t>(AUDIO_STREAM_FM), aIndex);
    mCurrentStreamVolumeTbl[AUDIO_STREAM_FM] = aIndex;
  }
}
-------------------------------------------------------------------------
Considering AudioChannel, it need to modify.

Comment 3

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v1

Remove the mFMChannelIsMuted, we already switch off the FMRadio audio path to mute the FMRadio sound.

Comment 4

[Marco Chen [:mchen]]

Comment on attachment 771930 [details] [diff] [review]
patch v1

Review of attachment 771930 [details] [diff] [review]:
-----------------------------------------------------------------

Actually this patch is the same with Bug 868960 and which was already landed to m-c.
So here will land it to b2g18 only based on leo+.

Hi Randy,
Is this align with you?

Thanks.

Comment 5

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Yes, just apply this patch to b2g18, thanks.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/73db89af09d3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/73db89af09d3

Comment 8

[Askeing Yen[:askeing][:fyen]]

Unagi
Gaia:     55ed5e08a2250ea2d3571fff860c39e66fabed14
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/6062fdf2deb8
BuildID   20130715070218
Version   18.0

Comment 9

[Askeing Yen[:askeing][:fyen]]

Helix
Gaia:     3042f9ec2fa8f7022647139217ad40560558f496
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/d3094c7c17e0
BuildID   20130715070212
Version   18.0

Verified.