Closed Bug 890421 Opened 11 years ago Closed 11 years ago

[Session Restore]"Don’t load tabs until selected" is broken, The contents would not load after select the restored tab.

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Version:
25 Branch
Platform:
x86_64
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 25
Tracking Flags:
Tracking Status
firefox24 --- unaffected
firefox25 + verified

People

(Reporter: alice0775, Assigned: ttaubert)

References

Details

(Keywords: regression)

Build Identifier: http://hg.mozilla.org/mozilla-central/rev/dcbbfcdf7bb4 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130704 Firefox/25.0 ID:20130704031323 The contents would not load after select the restored tab. Steps To Reproduce: 1. Open 3 tabs 2. Pinned a tab --- now [pinned][normal A][normal B] 3. Restart Browser 4. Click "Restore Previous Tabs" 5. Select a unselected background tab Actual Results: empty Expected Results: The contents should load after select the unselected tab Regression window(m-c) Good: http://hg.mozilla.org/mozilla-central/rev/614e1793e958 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130629 Firefox/25.0 ID:20130629173041 Bad: http://hg.mozilla.org/mozilla-central/rev/e24391ffbe7e Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130630 Firefox/25.0 ID:20130630083743 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=614e1793e958&tochange=e24391ffbe7e Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/3f5669a7cd14 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130630 Firefox/25.0 ID:20130630080142 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/fe2f77d51bf1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130630 Firefox/25.0 ID:20130630084042 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3f5669a7cd14&tochange=fe2f77d51bf1 Regression window(fx-team) Good: http://hg.mozilla.org/integration/fx-team/rev/52f605debfd4 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130627 Firefox/25.0 ID:20130627033223 Bad: http://hg.mozilla.org/integration/fx-team/rev/086465524970 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130627 Firefox/25.0 ID:20130627073223 Pushlog: http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=52f605debfd4&tochange=086465524970 Regressed by: 086465524970 Tim Taubert — Bug 887394 - Don't collect state right after startup when restoring the initial session; r=yoric
Error in STR s/4. Click "Restore Previous Tabs"/4. Click "Restore Previous Session"
OS: Windows 7 → All
status-firefox25: --- → affected
tracking-firefox25: --- → ?
Summary: Don’t load tabs until selected is broken, The contents would not load after select the restored tab. → [Session Restore]"Don’t load tabs until selected" is broken, The contents would not load after select the restored tab.
FTR, this is indeed caused by bug 887394. _prepDataForDeferredRestore() re-uses nsISessionStartup.state object and modifies it (boo). This leads to interesting side-effects like this one when we have a deferred session.
Depends on: 891360
Restored tabs still do Not load on click (focus) when FF is Started fresh, BUT if I use https://addons.mozilla.org/en-US/firefox/addon/restart-ff-button/ and 'Restart' FF tabs will load, reload when clicked on (given focus). Landis.
Assignee: nobody → ttaubert
status-firefox24: --- → unaffected
tracking-firefox25: ? → +
Fixed in today's Nightly.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
status-firefox25: affected → fixed
Target Milestone: --- → Firefox 25
Keywords: verifyme
I confirm the fix is verified on FF 25b2 using Mac OS 10.8.4, Ubuntu 13.04 x64 and Windows 7 x64 BuildID: 20130923194050
Status: RESOLVED → VERIFIED
status-firefox25: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.