890454 - [Homescreen] The save-bookmark screen doesn't work fine when "Add to Home Screen" button is pressed continuously.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

Description

[Leo]

1. Title : The save-bookmark screen doesn't work fine when "Add to Home Screen" button is pressed continuously.

2. Precondition : Connect the wifi or data

3. Tester's Action : Go to browser app -> open any URLs -> press the star button to save the bookmark -> show the save-bookmark screen -> Press the "Add to Home Screen" button immediately and continuously after showing the screen 

4. Detailed Symptom (ENG.) : "X" button doesn't work and "WEBSITE NAME" and "ADDRESS" label are empty. 

5. Version 
GAIA : f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3
GECKO : be276cf55ce160bca09f36d9ca679a2ae20ea7cc

6.Personal email id:  [e-mail]

Comment 1

[Leo]

Attachment: Attach the video

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 771571 [details]
Patch v1

Simple patch, tested on the phone, working well for me.

Thanks Cristian!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/7115b64f7dbf19a909ed8b75af94683903b0c118

Comment 5

[Cristian Rodriguez (:crdlc)]

thanks a lot

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 7115b64f7dbf19a909ed8b75af94683903b0c118 to:
v1-train: 4b829a509a72941d4482b6dd0fc8db0798c91eab

Comment 7

[Leo]

When I apply this patch, I can see same issue.
I think this issue is not solved. I reopen this issue.

Comment 8

[Cristian Rodriguez (:crdlc)]

I cannot reproduce the problem anymore, when an user clicks on this button, it is disabled then you cannot click on it more times

https://github.com/mozilla-b2g/gaia/pull/10806/files#L0R81

Could you explain the new STR? What URL are you bookmarking?

Thanks

Comment 9

[Cristian Rodriguez (:crdlc)]

I need help form QA please to reproduce it, thanks

Comment 10

[Jason Smith [:jsmith]]

leo - Can you file a new bug for the issue you hit?

Comment 11

[Jason Smith [:jsmith]]

I'll leave qawanted on though for the testing request on comment 9.

Comment 12

[:CSchmoeckel]

Able to reproduce this issue on both Leo and Unagi devices. Quickly tapping the bottom portion of the screen immediately after tapping the "Add to Home Screen" button causes the issues listed in the bug. Repro rate is 50% 5/10 with the issue not typically occurring on the first attempt. 
Build: 20130710070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/5b34e0cda635
Gaia: 61453c4d32beb15a33ec91b2e740e96e5ce45759
Platform Version: 18.1

Comment 13

[Wayne Chang [:wchang]]

Reopening per comment 12.
Cristian, can you follow this up still?

Comment 14

[Jason Smith [:jsmith]]

(In reply to Wayne Chang [:wchang] from comment #13)
> Reopening per comment 12.
> Cristian, can you follow this up still?

Patch is already landed at this point. We typically only reopen bugs if the patch is backed out from FIXED.

Instead, file followups instead. I've filed bug 892357 to track this.

Comment 15

[Cristian Rodriguez (:crdlc)]

I am going to fix the new one

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 4b829a509a72941d4482b6dd0fc8db0798c91eab