892357 - Followup to bug 890454 - [Homescreen] The save-bookmark screen doesn't work fine when "Add to Home Screen" button is pressed continuously.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

Description

[Jason Smith [:jsmith]]

Followup to bug 890454. Apparently https://bugzilla.mozilla.org/show_bug.cgi?id=890454#c12 reveals this is still reproducible even with the patch included.

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v2

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 773829 [details]
Patch v2

Please could you test it before landing? Thanks

Comment 3

[Leo]

When I apply the "Patch v2", same issue is reproduced...
Please check it again..

Comment 4

[Cristian Rodriguez (:crdlc)]

Sorry but I don't understand anything :( If you see the patch, the listener for the save button is removed the first time, I mean, with the first click is received:

save: function bookmarkEditor_save(evt) {
    this.addButton.removeEventListener('click', this.saveListener);

Comment 5

[Cristian Rodriguez (:crdlc)]

Umm interesting, in v1-train there is not this code

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/bookmark.js#L50

document.getElementById('bookmark-form').onsubmit = function() {
      return false;
    };

Comment 6

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v3

Comment 7

[Cristian Rodriguez (:crdlc)]

Could you test the patch v3?

Comment 8

[Leo]

When I apply v3 patch, same issue is reproduced.
I inserted the log in homescreen and test, I found some info

When issue is occured, 
1. If user select "Add to Home Screen", save and close function are not run.
2. If user select "Add to Home Screen", below log is occured 

/GeckoConsole(17563): [JavaScript Error: "document.getElementById(...) is null" {file: "app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js" line: 134}]
E/GeckoConsole(17563): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "document.getElementById(...) is null" {file: "app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js" line: 134}]' when calling method: [nsIDOMSystemMessageCallback::handleMessage]" {file: "jar:file:///system/b2g/omni.ja!/components/SystemMessageManager.js" line: 97}]
E/GeckoConsole(17563): [JavaScript Warning: "Expected pseudo-element but found '-moz-placeholder'.  Ruleset ignored due to bad selector." {file: "app://homescreen.gaiamobile.org/shared/style/input_areas.css" line: 40}]

Please check these information

Comment 9

[Cristian Rodriguez (:crdlc)]

Hi Leo,

   I apologize for this problem but I cannot reproduce in my Unagi. This problem is very revealing, there is a race condition, sometimes the BookmarkEditor component is loaded before the DOM and pumm! If you test the new patch [1], at least the race condition should disappear and maybe the editor could finally work fine. Sorry again but it is very difficult to fix something what someone cannot reproduce by himself.

Thanks

[1] https://github.com/mozilla-b2g/gaia/pull/10936.patch

Comment 10

[Leo]

(In reply to Cristian Rodriguez de la Cruz (:crdlc) from comment #9)
> Hi Leo,

   I apologize for this problem but I cannot reproduce in my Unagi.
> This problem is very revealing, there is a race condition, sometimes the
> BookmarkEditor component is loaded before the DOM and pumm! If you test the
> new patch [1], at least the race condition should disappear and maybe the
> editor could finally work fine. Sorry again but it is very difficult to fix
> something what someone cannot reproduce by himself.

When I apply comme9 patch, same issue is reproduced. But more rarely.

And other log is occured

E/GeckoConsole(23960): [JavaScript Error: "document.location is null" {file: "app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js" line: 134}]
E/GeckoConsole(23960): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "document.location is null" {file: "app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js" line: 134}]' when calling method: [nsIDOMSystemMessageCallback::handleMessage]" {file: "jar:file:///system/b2g/omni.ja!/components/SystemMessageManager.js" line: 97}]
E/GeckoConsole(23960): [JavaScript Warning: "Expected pseudo-element but found '-moz-placeholder'.  Ruleset ignored due to bad selector." {file: "app://homescreen.gaiamobile.org/shared/style/input_areas.css" line: 40}]

Comment 11

[Cristian Rodriguez (:crdlc)]

I am lost right now :) I don't know how document.location is null, it is a pain on the neck  jejeje

this.origin = document.location.protocol + '//homescreen.' +
      document.location.host.replace(/(^[\w\d]+.)?([\w\d]+.[a-z]+)/, '$2');

Comment 12

[Cristian Rodriguez (:crdlc)]

one question, is this trace before clicking or after?

Comment 13

[Cristian Rodriguez (:crdlc)]

Please, I've changed the patch a bit and added some traces, could you test it again?

https://github.com/mozilla-b2g/gaia/pull/10936.patch

Thanks a lot

Comment 14

[Leo]

Same issue is occured. I attach log

E/GeckoConsole(27269): Content JS LOG at app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js:137 in onActivity: The origin is: app://homescreen.gaiamobile.org
E/GeckoConsole(27269): [JavaScript Warning: "Expected pseudo-element but found '-moz-placeholder'.  Ruleset ignored due to bad selector." {file: "app://homescreen.gaiamobile.org/shared/style/input_areas.css" line: 40}]
E/GeckoConsole(27269): Content JS LOG at app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js:137 in onActivity: The origin is: app://homescreen.gaiamobile.org
E/GeckoConsole(27269): [JavaScript Error: "TypeError: this.oncancelled is not a function" {file: "app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js" line: 134}]
E/GeckoConsole(27269): [JavaScript Warning: "Expected pseudo-element but found '-moz-placeholder'.  Ruleset ignored due to bad selector." {file: "app://homescreen.gaiamobile.org/shared/style/input_areas.css" line: 40}]

Please check log. other log is occured also.

Comment 15

[Cristian Rodriguez (:crdlc)]

please strs?

Comment 16

[Leo]

And sometimes, 

E/GeckoConsole(28643): [JavaScript Error: "document.location is null" {file: "app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js" line: 136}]
E/GeckoConsole(28643): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "document.location is null" {file: "app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js" line: 136}]' when calling method: [nsIDOMSystemMessageCallback::handleMessage]" {file: "jar:file:///system/b2g/omni.ja!/components/SystemMessageManager.js" line: 97}]

These logs are shown.

Comment 17

[Leo]

When this case is occured, 

When I insert below log, document.location is null.

save-bookmark.js : 
=========================================
console.log("document.location : " + document.location);
if (data.type === 'url') {
  var origin = document.location.protocol + '//homescreen.' +
               document.location.host.
               replace(/(^[\w\d]+.)?([\w\d]+.[a-z]+)/, '$2');
  console.log('The origin is: ' + origin);
=========================================

Comment 18

[Cristian Rodriguez (:crdlc)]

Try it the last time

https://github.com/mozilla-b2g/gaia/pull/10936.patch

If the bug is still reproducible, maybe the problem is not in homescreen's code and other person could fix it

Thanks

Comment 19

[Leo]

Attachment: New issue

I apply this patch, this issue is not reproduced.

But new issue is occured. Check the image.

And device is changed this state, cannot close screen. Only can go home.(x button is not run)

Please check

Comment 20

[Cristian Rodriguez (:crdlc)]

STR? When does it happen?

Comment 21

[Leo]

I perform same. But, it is rarely occured. I test about 1~200 times, new issue is occured 2~3 times

Comment 22

[Leo]

Log is : 

E/GeckoConsole(  483): Content JS LOG at app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js:137 in onActivity: The origin is: app://homescreen.gaiamobile.org
E/GeckoConsole(  483): Content JS LOG at app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js:134 in bookmarkEditor_save: The save button was clicked
E/GeckoConsole(  483): [JavaScript Warning: "Expected pseudo-element but found '-moz-placeholder'.  Ruleset ignored due to bad selector." {file: "app://homescreen.gaiamobile.org/shared/style/input_areas.css" line: 40}]
E/GeckoConsole(  483): Content JS LOG at app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js:137 in onActivity: The origin is: app://homescreen.gaiamobile.org
E/GeckoConsole(  483): Content JS LOG at app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js:134 in bookmarkEditor_save: The save button was clicked
E/GeckoConsole(  483): [JavaScript Warning: "Expected pseudo-element but found '-moz-placeholder'.  Ruleset ignored due to bad selector." {file: "app://homescreen.gaiamobile.org/shared/style/input_areas.css" line: 40}]
E/GeckoConsole(  483): Content JS LOG at app://homescreen.gaiamobile.org/gaia_build_save-bookmark.js:137 in onActivity: The origin is: app://homescreen.gaiamobile.org

In this case, I don't search problem in logs...

Comment 23

[Cristian Rodriguez (:crdlc)]

I am writing a lot of traces in order to know what's happen when it fails. Although the first time it works fine, right? Thanks

Comment 24

[Cristian Rodriguez (:crdlc)]

Ready

https://github.com/mozilla-b2g/gaia/pull/10936.patch

Thanks for your great help!

Comment 25

[Cristian Rodriguez (:crdlc)]

Please make sure that this code:

document.readyState === 'interactive

is available in the patch what you are testing right now

Thanks a lot

Comment 26

[Leo]

I test 200 times, original issue and new issue are not reproduced.
I think issue is fixed.

Thanks for your help!

Comment 27

[Cristian Rodriguez (:crdlc)]

Thanks to you!! I couldn't fix it without your help

Comment 28

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1 ONLY for v1-train

Comment 29

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 30

[Cristian Rodriguez (:crdlc)]

master:

https://github.com/mozilla-b2g/gaia/commit/7cce92f408d64d3c66f9a533d34a477fe456d3e9

v1-train:

https://github.com/mozilla-b2g/gaia/commit/55ed5e08a2250ea2d3571fff860c39e66fabed14

Comment 31

[isabelrios]

Not able to reproduce this bug with unagi v1-train 07/19 build:
Gecko-6b60535
Gaia-4abea64
ref ril

Comment 32

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 55ed5e08a2250ea2d3571fff860c39e66fabed14
v1.1.0hd: bd6659f4c2cb03e09d5ce5bda54a92d2015b9ec5