890694 - Add EAP-SIM/AKA/AKA' support

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, enhancement)

Description

[Masashi Honma]

Dimi Lee proposed EAP-SIM architecture.
https://groups.google.com/forum/#!topic/mozilla.dev.b2g/XXKZnu8-vpk

This patch includes only Gaia/Gecko side. The pcsc_funcs modification (from wpa_supplicant to RIL code) is not included. Because I do not have connection to SIM vendor.

I hope this patch helps working of Dimi Lee team.
This patch could be land with any risk.
Because EAP connection is disabled on default.

This Bug is not depends on Bug 789217. Because EAP-SIM/AKA/AKA' does not require any certificate.

Comment 1

[Masashi Honma]

Attachment: Gecko Patch

Comment 2

[Masashi Honma]

Attachment: Gaia Patch

Comment 3

[Masashi Honma]

Dimi Lee,
Is there any comment ?
If you are not reviewer, can you introduce appropriate reviewer ?

Comment 4

[Dimi Lee [ooo 16.04 - 21.04］]

Hi Masashi Honma
  This patch is good, thanks
  I am sorry for late review, i didn't notice it.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/134040a98d40

Comment 6

[Masashi Honma]

Dimi Lee,
Thanks for review for Gecko patch.
How about Gaia patch ?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/134040a98d40

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Vincent, did you aware this?
I don't think Dimi is a reviewer.

Comment 9

[Vincent Chang[:vchang][changyihsin]]

(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #8)
> Vincent, did you aware this?
> I don't think Dimi is a reviewer.
Hi Yoshi, thanks for your reminding.

Comment 10

[Vincent Chang[:vchang][changyihsin]]

Hi Masashi san, thanks for your support. It's really helpful. In case you may want to look for reviewer next time for wifi related code, current reviewers should be 

Gecko part, [e-mail], [e-mail]
Gaia part, [e-mail], [e-mail], [e-mail] 

For others module, you can check this url.
https://wiki.mozilla.org/Modules/FirefoxOS

Comment 11

[Masashi Honma]

Thank you Vincent Chang.

I have selected Dimi Lee as reviwer, because this patch requires knowledge for EAP-SIM/AKA/AKA' and he has it.

Now I understand he is not a reviewer.

I change reviewer to arthur.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 771829 [details]
Gaia Patch

Masashi, thank you for the patch! 

The current patch leads to null error when navigating to `wifi-joinHidden` panel. Details please refer to github comments.

Comment 13

[Masashi Honma]

Arthur Chen,
Thanks for your review.
I fixed the patch.

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 771829 [details]
Gaia Patch

Thank you for the patch! r=me. However, I have two additional comments in github. Please address them and squash the commits before merging.

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: https://github.com/mozilla-b2g/gaia/commit/05d8283cc077336289f5bff97abbf06eaae2d5eb

Comment 16

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

AKA/AKA' will not be enabled in v1.3 (disabled from GAIA), because of following reasons: 
1. we don't have the approach/device to test it
2. no clear requirements at this moment
Bug 944226 created for tracking.