Closed Bug 890726 Opened 6 years ago Closed 6 years ago

HTML validation strings are always in English on localized builds

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Tracking Status
firefox22 --- unaffected
firefox23 - affected
firefox24 - affected

People

(Reporter: flod, Assigned: Pike)

References

Details

Attachments

(3 files)

Running Fennec in Italian (nightly), html validation messages are displayed in English.

These strings are part of dom.properties (FormValidation*)
http://hg.mozilla.org/l10n-central/it/file/96eb867b0f00/dom/chrome/dom/dom.properties

I believe this is a regression from bug 792077
Where does that string show on Android?

If we need dom.properties for the UI, we should add it to http://hg.mozilla.org/mozilla-central/file/f8a08d0a1b2a/mobile/android/locales/jar.mn#l60.
Attached file Minimal form
They're displayed near the fields with constraints. See for example this form with a required field.
I take it you ran that through an Italian build?

Anywho, yes, we should fix this and upstream it. Requesting tracking 'til 23, which is where we shipped the original patch.
Yes, Italian build, verified on both nightly (fx25) and beta (fx23).
Attached image Screenshot with fx22
(In reply to Axel Hecht [:Pike] from comment #4)
> Anywho, yes, we should fix this and upstream it. Requesting tracking 'til
> 23, which is where we shipped the original patch.

Should we consider backing out bug 792077 on FF23 until this is resolved? We're concerned this may be a canary in the coalmine for other l10n issues.
Assignee: nobody → l10n
IMHO, we should keep the current patch. Neither this nor the about pages are a major regression, and I'll create a patch this week. flod had good input on what's needed.
(In reply to Axel Hecht [:Pike] from comment #8)
> IMHO, we should keep the current patch. Neither this nor the about pages are
> a major regression, and I'll create a patch this week. flod had good input
> on what's needed.

I've got a slight concern for about:crashes not in the users language that's about it re: about:pages
(In reply to Aaron Train [:aaronmt] from comment #9)
> (In reply to Axel Hecht [:Pike] from comment #8)
> > IMHO, we should keep the current patch. Neither this nor the about pages are
> > a major regression, and I'll create a patch this week. flod had good input
> > on what's needed.
> 
> I've got a slight concern for about:crashes not in the users language that's
> about it re: about:pages

Any about: page that requires typing in the URL bar is probably low priority. I hope we get a fix, but I agree with Axel that the severity level is low.
(In reply to Mark Finkle (:mfinkle) from comment #10)
> Any about: page that requires typing in the URL bar is probably low
> priority.

I agree.
This was fixed in bug 891118
https://hg.mozilla.org/mozilla-central/rev/c1443b4d7e51

Verified on Firefox 25.0a1 (2013-07-13)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Depends on: 915721
You need to log in before you can comment on or make changes to this bug.