891118 - Some about: pages are in English in localized builds

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alexander L. Slovesnik]

Some about: pages are in English in localized build in Fx 23 Beta 3, like:
about:support, about:crashes, about:mozilla, about:plugins, about:healthreport and about:telemetry
Looks like it's been caused by Bug 792077

Comment 1

[Francesco Lodolo [:flod]]

about:healthreport
String are outside of Firefox and the mobile version is still not ready (Fx22 doesn't have that URL enabled).

Confirming the other pages though.

about:support
/toolkit/locales/en-US/chrome/global/aboutSupport.dtd
/toolkit/locales/en-US/chrome/global/aboutSupport.properties

about:crashes
/toolkit/locales/en-US/crashreporter/crashes.dtd
/toolkit/locales/en-US/crashreporter/crashes.properties

about:mozilla
/toolkit/locales/en-US/chrome/global/mozilla.dtd

about:plugins
/dom/locales/en-US/chrome/plugins.properties

about:telemetry
/toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd
/toolkit/locales/en-US/chrome/global/aboutTelemetry.properties

Comment 2

[Axel Hecht [:Pike]]

re about:healthreport, one string is inside the browser, but we're covered for that,http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutHealthReport.xhtml

Comment 3

[Paul Feher]

I have tested today the localization on Firefox for Android 23 Beta 4 on Asus Eee Transformers (Android 4.0.4). I did not encountered any issues on about:firefox pages. Can you provide more details on which pages using which language, or if you used the multi languages build. Also there is no Fx 23 Beta 3 for android.

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Paul Feher from comment #3)
> I have tested today the localization on Firefox for Android 23 Beta 4 on
> Asus Eee Transformers (Android 4.0.4). I did not encountered any issues on
> about:firefox pages. Can you provide more details on which pages using which
> language, or if you used the multi languages build. Also there is no Fx 23
> Beta 3 for android.

Please read comment 1, nobody found problems with about:firefox (not sure where you got that) ;-)

Comment 5

[Alex Keybl [:akeybl]]

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=890726#c7 for triage's concerns about bug 792077 in FF23.

Comment 6

[Axel Hecht [:Pike]]

Taking, and my reply to the concerns is also in bug 792077.

Comment 7

[Axel Hecht [:Pike]]

Attachment: fix about pages and validation, too

Just more files, I'm fixing both this bug and the validation bug 890726 in one patch, as that's easier.

I tested the about pages and the validation on the simulator, aside from about:crashes, which isn't enabled on my local build.

Comment 8

[Axel Hecht [:Pike]]

Pushed to inbound, https://hg.mozilla.org/integration/mozilla-inbound/rev/c1443b4d7e51

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c1443b4d7e51

Comment 10

[Alex Keybl [:akeybl]]

We'll look at an approval request, but no need to track given discussion in bug 890726.

Comment 11

[Axel Hecht [:Pike]]

It'd be great if we could get verification on trunk, Italian and French are good languages to test.

Then I'll request uplifts.

Comment 12

[Francesco Lodolo [:flod]]

I'm on it, waiting for a new build (2013-07-12 doesn't have the fix)

Comment 13

[Francesco Lodolo [:flod]]

Verified on Firefox 25.0a1 (2013-07-13)

about:support
about:crashes
about:mozilla
about:plugins
about:telemetry

All these pages appear correctly localized

Comment 14

[Axel Hecht [:Pike]]

Comment on attachment 773937 [details] [diff] [review]
fix about pages and validation, too

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 792077 made us do sparse l10n for toolkit, and too sparse
User impact if declined: several about: pages aren't localized
Testing completed (on m-c, etc.): verified on nightly
Risk to taking this patch (and alternatives if risky): low, just including more existing files from desktop
String or IDL/UUID changes made by this patch: no new strings, just packaging existing strings.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Already landed on Aurora.
https://hg.mozilla.org/releases/mozilla-aurora/rev/69bdfec92dba

Pike, if you're going to push to the release branches, you must update the bug accordingly per the tree rules so others don't waste their time attempting to do the same.

Comment 16

[Francesco Lodolo [:flod]]

Verified on Aurora 24.0a2 (2013-01-17)

Comment 17

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 24.0a2( 2013-07-17)
Device: Acer Iconia
OS: Android 3.2

Comment 18

[Axel Hecht [:Pike]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3b4a649104aa, landed on beta, setting status-firefox23 to fixed.

Comment 19

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 23.0b8(2013-07-23)
Device: Samsung Galaxy R
OS: Android 2.3