Open
Bug 890944
Opened 12 years ago
Updated 4 months ago
GenerationalGC: IonMonkey: NewObject should nursery-allocate dynamic slots
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
NEW
People
(Reporter: jandem, Unassigned)
References
(Blocks 1 open bug)
Details
Similar to bug 890937 and bug 890943.
|
||
Comment 1•11 years ago
|
||
I think with bug 969012, we now just have to change MNewObject::shouldUseVM and remove the !templateObject()->hasDynamicSlots() check.
|
Reporter | |
Comment 2•11 years ago
|
||
(In reply to Tom Schuster [:evilpie] from comment #1)
> I think with bug 969012, we now just have to change MNewObject::shouldUseVM
> and remove the !templateObject()->hasDynamicSlots() check.
needinfo? Terrence; this sounds like a potential easy perf win (also bug 890943).
Flags: needinfo?(terrence)
|
||
Comment 3•11 years ago
|
||
Oh, if only it were that simple. Since NewObject is only for {} literals, shouldUseVM is only called 238 times *total* on all of octane. Both conditions are always false. Something else higher up the stack is making sure that objects with dynamic slots never even make it to IonBuilder. I have no idea what.
Flags: needinfo?(terrence)
|
Assignee | |
Updated•11 years ago
|
Assignee: general → nobody
|
||
Updated•3 years ago
|
Severity: normal → S3
|
||
Comment 4•4 months ago
|
||
Is this still relevant?
You need to log in
before you can comment on or make changes to this bug.
Description
•