Closed
Bug 890950
Opened 11 years ago
Closed 11 years ago
Upload textures in BGRA format on OSX
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file)
|
17.86 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
OSX drivers use this format internally (even with LOCAL_GL_RGBA set as the internal format), and will swizzle RGBA uploads (on the cpu for glTexSubImage2D). It should be much faster to pretend our source data is BGRA and swizzle using shaders during drawing.
Attachment #772100 -
Flags: review?(jmuizelaar)
|
Assignee | |
Comment 1•11 years ago
|
||
Comment on attachment 772100 [details] [diff] [review] Upload using BGRA Review of attachment 772100 [details] [diff] [review]: ----------------------------------------------------------------- r=jrmuizel in person while bugzilla and power was out.
Attachment #772100 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/46f85b38be9b
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/46f85b38be9b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
|
||
Comment 4•11 years ago
|
||
For me, http://ie.microsoft.com/testdrive/Performance/Bubbles/ goes from ~15fps to ~50fps with this change.
|
|
||
Updated•11 years ago
|
Assignee: nobody → matt.woodrow
You need to log in
before you can comment on or make changes to this bug.
Description
•