892467 - Window control buttons (close, min, max) show the wrong colors

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Mike de Boer [:mikedeboer]]

Attachment: Shiny!

UX branch now show a very fancy golden look, if you're using the OSX graphite theme.

Comment 1

[Morpheus3k]

Attachment: Wrong colors (Default OS X Theme)

On the default OS X Theme (Blue) I've got nice new colors for the window control buttons.

Comment 2

[Mike de Boer [:mikedeboer]]

When Australis lands, we'll change the name to GirlyFox right away.

/me runs off to find a nice pink theme to replace our default one with!

Comment 3

[Markus Stange [:mstange]]

Hah! Looks like something went wrong when I merged bug 882523 with bug 867460.

Comment 4

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

I am getting a repo of this on non UX nightly now. When I spawn a new private browsing window

Comment 5

[Markus Stange [:mstange]]

In fact it was bug 890950! Matt, your turn. :-)

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Use correct shader in RectTextureImage

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 774336 [details] [diff] [review]
Use correct shader in RectTextureImage

Do we want to get rid of the whole BGRARectLayerProgramType stuff?

Comment 8

[Matt Woodrow (:mattwoodrow)]

Nope, we still use them on other platforms.

Comment 9

[Markus Stange [:mstange]]

The rect one? I added it in bug 882523.

Comment 10

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4e1cb3ced2f

Comment 11

[Justin Dolske [:Dolske]]

This is, approximately, the best bug evar. EVAR.

Can we have a pref to keep the blues? :D

Comment 12

[Rangi]

(In reply to Justin Dolske [:Dolske] from comment #11)
> This is, approximately, the best bug evar. EVAR.
> 
> Can we have a pref to keep the blues? :D

Yes please!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d4e1cb3ced2f