The default bug view has changed. See this FAQ.

[uk] Search engine setup for Firefox Mobile for Ukranian

RESOLVED FIXED in mozilla25

Status

Mozilla Localizations
uk / Ukrainian
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gueroJeff, Assigned: Tim Babych)

Tracking

({productization})

unspecified
mozilla25
x86
All
productization

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

4 years ago
We want to ship Firefox Mobile with a good list of search engines for Ukranian.

We're going to work towards this in three phases. First, the localization team and the l10n drivers will look at the market for the language and come up with a good set of search providers. Tim, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Mobile/Productization> and <https://developer.mozilla.org/en-US/docs/Productization_guide>.

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:

> Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to desktop, 32x32 icon)

Once we decide to use a particular search engine (and we test it on a mobile device), l10n drivers will contact the owner and ask for permission, and for specifics like proper search flags. Tim, we'll likely need your help to at least get the contact information.

For search engines that we already ship with on desktop and that you would like to include in mobile as well, the permission is not needed. Consider using a mobile version of the engine if one is available. Also, please make yourself familiar with instructions regarding the <Description/> element at <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions>.

Once we have a specification on what the search engines for Ukranian should look like, Milos and the localization team will work on an implementation on that. Milos will create and attach patches for the desired changes and get them reviewed. After a successful review, Milos will land them. Tim, if you're interested, you could create the patches, too. You'd ask Milos for review on those before landing.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Milos, Jeff, Axel or someone else appointed by the l10n drivers. The data here is sensitive to users and our search partners, thus the extra care here.

The Ukranian team and Milos will be driving this bug to completion.
(Reporter)

Comment 1

4 years ago
For Ukranian, we're shooting for inclusion into Firefox 25, which is currently on Nightly. We have until September 16th at the latest to include this into that version once it's in Aurora.
(Reporter)

Comment 2

4 years ago
Hi Tim!

Firefox 25 is now in Aurora, so we can begin working on productization for this upcoming release. Could you look into this over this week please?

Thanks :-)
(Reporter)

Updated

4 years ago
Assignee: nobody → tim.babych
(Reporter)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

4 years ago
Hello, Jeff.

I looked around and asked our community and we will go with following engines:

1. Google
2. Wikipedia (uk)
3. Twitter
4. Market.Yandex.ua

I had talks with Yandex representatives few years ago, they were enthusiastic about being included. I will ask them to comment in the ticket.
(Reporter)

Comment 4

4 years ago
(In reply to Tim Babych from comment #3)
> Hello, Jeff.
> 
> I looked around and asked our community and we will go with following
> engines:
> 
> 1. Google
> 2. Wikipedia (uk)
> 3. Twitter
> 4. Market.Yandex.ua
> 
> I had talks with Yandex representatives few years ago, they were
> enthusiastic about being included. I will ask them to comment in the ticket.

Hey Tim,

That's fantastic! Looking forward to hearing from them here. In the mean time, are you able to create a patch for these search engines, or would you like some help with that? In case you need it, the instructions for making these productization patches are on: https://developer.mozilla.org/en-US/docs/Productization_guide

Thanks!
Jeff

Comment 5

4 years ago
Hey Jeff,
My name is Vadim, I represent Yandex.

As Tim mentioned we are looking pretty enthusiastic on an opportunity to provide Ukrainian Firefox users Yandex.Market for their shopping needs.

Jeff, do we need to do something special or just to comment that we agree?

Comment 6

4 years ago
Hey Jeff,
My name is Vadim, I represent Yandex.

As Tim mentioned we are looking pretty enthusiastic on an opportunity to provide Ukrainian Firefox users Yandex.Market for their shopping needs.

Jeff, do we need to do something special or just to comment that we agree?

Best regards,
Vadim
Hi Vadim,
this is the current searchplugin used on Firefox desktop
http://hg.mozilla.org/releases/l10n/mozilla-aurora/uk/file/5fc6eb4d2bb4/browser/searchplugins/yandex.xml

Here are some questions:
* Does the search query have to contain specific parameters to identify mobile users (like the from parameter on Desktop)? 
* Do you have a mobile version of the website that could be used on phones for a better experience (i.e. search and suggestion URL specific for mobile)?
* Some search engines require not to mix up channel identifications for tablet (same as for desktops) and mobile devices. Does Yandex require that? Does Yandex do mobile vs desktop detection?
* Can you provide a 32x32px icon (the current one is 16x16)?
(Assignee)

Comment 8

4 years ago
Francesco, please note that desktop plugin is Yandex general search, while one under discussion is price-comparison search. They have http://market.yandex.ua/opensearch.xml, which is a good starting point for creating a patch.

I will leave to Vadim to answer rest of the questions.
(In reply to Tim Babych from comment #8)
> Francesco, please note that desktop plugin is Yandex general search, while
> one under discussion is price-comparison search. They have
> http://market.yandex.ua/opensearch.xml, which is a good starting point for
> creating a patch.

Thanks, missed that. Questions remain valid, plus "Does market.yandex.ua" support suggestions (I don't see them in the linked searchplugin)?
(Reporter)

Comment 10

4 years ago
(In reply to Vadim from comment #6)
> Hey Jeff,
> My name is Vadim, I represent Yandex.
> 
> As Tim mentioned we are looking pretty enthusiastic on an opportunity to
> provide Ukrainian Firefox users Yandex.Market for their shopping needs.
> 
> Jeff, do we need to do something special or just to comment that we agree?
> 
> Best regards,
> Vadim

Hi Vadim,

Great to hear from you! Answers to Flod's technical questions and your written approval on this bug are fantastic.

Thank you,
Jeff

Comment 11

4 years ago
Hi Flod, Tim, Jeff,

I'll provide the answers soon (most probably today).

Best,
Vadim

Comment 12

4 years ago
Sorry for the delay.

1. Here is the favicon in right sizes - http://yadi.sk/d/IYcahhXQ8dYjh
2. There is no need to make a special parameter for market.yandex.ua 
3. For touchphones, please use the following URL http://m.market.yandex.ua
4. For the tablets http://market.yandex.ua as for laptop and desktop versions
(Assignee)

Comment 13

4 years ago
Created attachment 798934 [details] [diff] [review]
Proposed search engine changes
Comment on attachment 798934 [details] [diff] [review]
Proposed search engine changes

Review of attachment 798934 [details] [diff] [review]:
-----------------------------------------------------------------

Since Yandex Market support both a desktop and a mobile version, you can take a look at bug 891604 or bug 850984 to see how it is possible to create a searchplugin able to use different URLs for tablets and phones.

::: mobile/searchplugins/wikipedia-uk.xml
@@ +2,4 @@
>  <ShortName>Вікіпедія</ShortName>
>  <Description>Вбудований пошук по Вікіпедії</Description>
>  <InputEncoding>UTF-8</InputEncoding>
> +<Image width="32" height="32">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAQAAADZc7J/AAAACXBIWXMAAAsTAAALEwEAmpwYAAADGGlDQ1BQaG90b3Nob3AgSUNDIHByb2ZpbGUAAHjaY2BgnuDo4uTKJMDAUFBUUuQe5BgZERmlwH6egY2BmYGBgYGBITG5uMAxIMCHgYGBIS8/L5UBFTAyMHy7xsDIwMDAcFnX0cXJlYE0wJpcUFTCwMBwgIGBwSgltTiZgYHhCwMDQ3p5SUEJAwNjDAMDg0hSdkEJAwNjAQMDg0h2SJAzAwNjCwMDE09JakUJAwMDg3N+QWVRZnpGiYKhpaWlgmNKflKqQnBlcUlqbrGCZ15yflFBflFiSWoKAwMD1A4GBgYGXpf8EgX3xMw8BSMDVQYqg4jIKAUICxE+CDEESC4tKoMHJQODAIMCgwGDA0MAQyJDPcMChqMMbxjFGV0YSxlXMN5jEmMKYprAdIFZmDmSeSHzGxZLlg6WW6x6rK2s99gs2aaxfWMPZ9/NocTRxfGFM5HzApcj1xZuTe4FPFI8U3mFeCfxCfNN45fhXyygI7BD0FXwilCq0A/hXhEVkb2i4aJfxCaJG4lfkaiQlJM8JpUvLS19QqZMVl32llyfvIv8H4WtioVKekpvldeqFKiaqP5UO6jepRGqqaT5QeuA9iSdVF0rPUG9V/pHDBYY1hrFGNuayJsym740u2C+02KJ5QSrOutcmzjbQDtXe2sHY0cdJzVnJRcFV3k3BXdlD3VPXS8Tbxsfd99gvwT//ID6wIlBS4N3hVwMfRnOFCEXaRUVEV0RMzN2T9yDBLZE3aSw5IaUNak30zkyLDIzs+ZmX8xlz7PPryjYVPiuWLskq3RV2ZsK/cqSql01jLVedVPrHzbqNdU0n22VaytsP9op3VXUfbpXta+x/+5Em0mzJ/+dGj/t8AyNmf2zvs9JmHt6vvmCpYtEFrcu+bYsc/m9lSGrTq9xWbtvveWGbZtMNm/ZarJt+w6rnft3u+45uy9s/4ODOYd+Hmk/Jn58xUnrU+fOJJ/9dX7SRe1LR68kXv13fc5Nm1t379TfU75/4mHeY7En+59lvhB5efB1/lv5dxc+NH0y/fzq64Lv4T8Ffp360/rP8f9/AA0ADzT6lvFdAAAAIGNIUk0AAHolAACAgwAA+f8AAIDpAAB1MAAA6mAAADqYAAAXb5JfxUYAAAHqSURBVHjapJUxb9NQFIW/JAip2xNS1/J+goeqUqeajdGVmFgwI1OcmYEgITFG7EgJQ+b2HzgbElJF+QU2iBl7YAFRnQ5+fnFcB0J8Jp/r53vPu+f6vYEA4JBTTjhkN/zkio9kAAihpyr1v/ijN7ovEHqiffFeDHTAdx6wL46HnPX4HM6HHNEHR0NGvRKMhvRE7wT3ACYssBggpyThIRMCAFaEzHhOiQWumfGFBQGQY0kB9EKSCsVCyKpQxUMhdOEMj4Vi91wIGX2uyNJtwTDHAgbjOUBJ/T50ETDAzCn0CiRpLkSd2VW1rqZR6uOpzHoWl40EkmkIlTIhNJc0bUSlSNNtCaZCKGtpyDZimXB92uhBhTEAHzx/BuQ8Isb62Dti16c7PahrNnbovFhXLGQaau4oqDSULDx/BcCl55cEDTUdCqqagWcXbjpqWD8ZWxRUGq5ZOTYhAXLHV0DU/qCtQLJCkZuM0PHQGThvL152JJh5M61SP2CpMpmmgdsTFDJCiaaubq0haQ7Q3xLUZq4NqzS0DNzWxNq8ksgbFmGgwf95oFgijJuB6v9L3Fx2HSg3XeExZxv1xuSEXQt/o8fqg9cDHfB15zuxjRuOETrfu/5b9bhcf+mlRmLgr/cTgp1vqR9c8YlvALcDAPr5jIx+4LKcAAAAAElFTkSuQmCC</Image>

Icon must be 32x32, but still have width and height set to 16. See for example the en-US searchplugin
http://hg.mozilla.org/mozilla-central/file/default/mobile/locales/en-US/searchplugins/wikipedia.xml

::: mobile/searchplugins/yandex-market.xml
@@ +1,5 @@
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>Яндекс.Маркет</ShortName>
> +<Description>Вибір моделей та пошук товарів.</Description>
> +<InputEncoding>UTF-8</InputEncoding>
> +<Image width="32" height="32">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyRpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMy1jMDExIDY2LjE0NTY2MSwgMjAxMi8wMi8wNi0xNDo1NjoyNyAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNiAoTWFjaW50b3NoKSIgeG1wTU06SW5zdGFuY2VJRD0ieG1wLmlpZDo4QzFGQTU0MTAyMDYxMUUzQUVGNDgzOTQ2MUY4REQ4MSIgeG1wTU06RG9jdW1lbnRJRD0ieG1wLmRpZDo4QzFGQTU0MjAyMDYxMUUzQUVGNDgzOTQ2MUY4REQ4MSI+IDx4bXBNTTpEZXJpdmVkRnJvbSBzdFJlZjppbnN0YW5jZUlEPSJ4bXAuaWlkOjhDMUZBNTNGMDIwNjExRTNBRUY0ODM5NDYxRjhERDgxIiBzdFJlZjpkb2N1bWVudElEPSJ4bXAuZGlkOjhDMUZBNTQwMDIwNjExRTNBRUY0ODM5NDYxRjhERDgxIi8+IDwvcmRmOkRlc2NyaXB0aW9uPiA8L3JkZjpSREY+IDwveDp4bXBtZXRhPiA8P3hwYWNrZXQgZW5kPSJyIj8+UJmW6wAABctJREFUeNq0V2tsFFUU/mbuzOyr7e72sS1tacsrRfhR5R0NQkxB4wslMZEEook/DIm/TEz55T8TSYz+EEOMicYXfyCGZ4kR0cSADxoVqIALpKWlhW53u+1ud3fe45m7Xehz20I9yc3evXPm3nO+851z7gj7jlwGF8epNHTjbdOwdtq23UQrHsxTLNtEeiiBkaEhyB4/mOKBIAiFx5rIxG5Jlo8qXs8HgiDG3UXJsR3Ylr1OzaonHcepxkOICIZgeQSiyBCP3YVPFCEyCcgb4bFMq5lGm65pr/sDJc+LEusQydtINpNtt2yr2nZsLMQIBMOQGIOuZmHbFoHrTBjkcHUmnW53fyU1p7dZllOFBZbK2gbcvhmFwGRIsqeAwjhxqtRcrk0yDGOHa/VCC5MVlIbDyKTSECgkPBSTxND0HRKRrgH/kwQrapBKDtNBKiQipTAJBQpPg2TbjlxY2LN1BbasXnRPITaSw4fHLiOeVh/QBAEV1bWI9fXCKzBCReZr40SSTPs+/F2xFBqrAnwuSyLqygPYvLoah893PTAKsr8UlHZEyBwUQeThmGABMfHen7MX+/jgLzIRB/duRktjBfoTGWiGjaxmwiB9zbD4XDdtGKaFDM2LSShSj/6uPCGZPKE2QLJse4aiYuPGnRGsrAvhjdaVs3rqGqObecNU3cIPF2/j587+sQLBiJAVSA8n4RHECYSUKAVn3PRKbxLNZMDx37vRSyh4ZYZdTy5He0cPPDTf9lg9LkRjUGi+Zmkl+khHkRjqKgJ45Yll+HEMTVf8ZZVEyDh0LUeE9BEKYsEAa0YDOrsTeGljE/fsl878Zi9uaMSRczf4fFNzBJ+cypfyj9/cjHe//YPP339tEwJeGZP3DlbWId7XQzSUII4RUjKLIHCVEHChba4PIxzwUoklNEUBDVWl/ACZvF23IgKJHrgotD66mCNTWeZDb3wUk/cWFT8Uvx+aloEslHBCFkUgR8+u9w/jETJg77OrMKoaPAytLXVUch0w4lJjVQmyqgm3p2g6kdQw4VWoF6RymG7vkvIaxG5FyZp8hSQSOkXJ5YbB5cE3P0Vx7XYSn761FQdO5mFvWVKJr8/+y+fb1yzG93/2YFG5n9f7Qaoh0+8tIhCuwuhIkqYSGWBaRQ241BXHzseXUjYE8U93nKqXDYk8j4R8lKoCR8Odl/lkvLdnA2rCAW5AD9WUmfZWfGUwB+5QShIZn2r7rigELuSH9j2NkYyGobSG5bXBGXVHMjpVzyyu9iTx1ZlrvGZMJw51yERvFEpJqDgHeMMQHIqljVDAwz270pPA4HAOMXfQYbGx+cBwFrphzak6qqlBXhtc3kiWVbwTrl1ZQ71dwGenO3H0/M2HblCOZWJ0KA7ZV0IOFamEBdnSUs9T8cxfPZhNdy6STfQR99xbEuOISrZZvI43RUrBKPcP7XtmzoccPPE3jk+DlkX5r2dHIXtd721CwzVgFg58cfoSWtc2QZxyo5lZegdSmLIveZvh3nvhuGWYp6jLAbM4rGc6uvmQqDuas/ClmI6RoRQmj0U5Tz6i9lg7nkNc33l1I7avX4L2327io8MX5q3j0HU9l0pQEyLo+f/7Z4o2sbLYYJSG29Yt4Yzdvn4pz+H56qjJPqr7ChFPzHtPBhSGey1HsaHpBk79ep2H7MS5KK/v89Ex1TQMVSXS51k/+V1h1a4DhhuKWW+5lAmz9Y2pOg7UxC0IdENmRL6pV3OYEq3dIsYum80Acw4lYLKOmU3AXWKCxLsnj9H4tsRYr0j39+O2+3m20MPUoWeG6f6Qv3iMj3thyIpyjK7r3v1aNrObFhb060hPDVBgPbzlOs7U0AmiOOgJlOyniiAMBILB5+g3tlDeW1oalqFTyPOHT/acZDAQCr1Av3dZ7dqXXWv6FZ/3S9IWiA8ReqmU5gyFuM11uOmnE+uzI1RwvGTAuG8AQTAYY910Jfs8EArvZkyOusv/CTAAht0nYPLRc7YAAAAASUVORK5CYII=</Image>

Same here for the icon.
(Assignee)

Comment 15

4 years ago
Created attachment 799064 [details] [diff] [review]
Updated search with icon sizes and tablet detection
Attachment #798934 - Attachment is obsolete: true
Comment on attachment 799064 [details] [diff] [review]
Updated search with icon sizes and tablet detection

Review of attachment 799064 [details] [diff] [review]:
-----------------------------------------------------------------

Don't forget to set a reviewer when you submit a patch ;-)

::: mobile/searchplugins/yandex-market.xml
@@ +4,5 @@
> +<InputEncoding>UTF-8</InputEncoding>
> +<Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyRpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMy1jMDExIDY2LjE0NTY2MSwgMjAxMi8wMi8wNi0xNDo1NjoyNyAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNiAoTWFjaW50b3NoKSIgeG1wTU06SW5zdGFuY2VJRD0ieG1wLmlpZDo4QzFGQTU0MTAyMDYxMUUzQUVGNDgzOTQ2MUY4REQ4MSIgeG1wTU06RG9jdW1lbnRJRD0ieG1wLmRpZDo4QzFGQTU0MjAyMDYxMUUzQUVGNDgzOTQ2MUY4REQ4MSI+IDx4bXBNTTpEZXJpdmVkRnJvbSBzdFJlZjppbnN0YW5jZUlEPSJ4bXAuaWlkOjhDMUZBNTNGMDIwNjExRTNBRUY0ODM5NDYxRjhERDgxIiBzdFJlZjpkb2N1bWVudElEPSJ4bXAuZGlkOjhDMUZBNTQwMDIwNjExRTNBRUY0ODM5NDYxRjhERDgxIi8+IDwvcmRmOkRlc2NyaXB0aW9uPiA8L3JkZjpSREY+IDwveDp4bXBtZXRhPiA8P3hwYWNrZXQgZW5kPSJyIj8+UJmW6wAABctJREFUeNq0V2tsFFUU/mbuzOyr7e72sS1tacsrRfhR5R0NQkxB4wslMZEEook/DIm/TEz55T8TSYz+EEOMicYXfyCGZ4kR0cSADxoVqIALpKWlhW53u+1ud3fe45m7Xehz20I9yc3evXPm3nO+851z7gj7jlwGF8epNHTjbdOwdtq23UQrHsxTLNtEeiiBkaEhyB4/mOKBIAiFx5rIxG5Jlo8qXs8HgiDG3UXJsR3Ylr1OzaonHcepxkOICIZgeQSiyBCP3YVPFCEyCcgb4bFMq5lGm65pr/sDJc+LEusQydtINpNtt2yr2nZsLMQIBMOQGIOuZmHbFoHrTBjkcHUmnW53fyU1p7dZllOFBZbK2gbcvhmFwGRIsqeAwjhxqtRcrk0yDGOHa/VCC5MVlIbDyKTSECgkPBSTxND0HRKRrgH/kwQrapBKDtNBKiQipTAJBQpPg2TbjlxY2LN1BbasXnRPITaSw4fHLiOeVh/QBAEV1bWI9fXCKzBCReZr40SSTPs+/F2xFBqrAnwuSyLqygPYvLoah893PTAKsr8UlHZEyBwUQeThmGABMfHen7MX+/jgLzIRB/duRktjBfoTGWiGjaxmwiB9zbD4XDdtGKaFDM2LSShSj/6uPCGZPKE2QLJse4aiYuPGnRGsrAvhjdaVs3rqGqObecNU3cIPF2/j587+sQLBiJAVSA8n4RHECYSUKAVn3PRKbxLNZMDx37vRSyh4ZYZdTy5He0cPPDTf9lg9LkRjUGi+Zmkl+khHkRjqKgJ45Yll+HEMTVf8ZZVEyDh0LUeE9BEKYsEAa0YDOrsTeGljE/fsl878Zi9uaMSRczf4fFNzBJ+cypfyj9/cjHe//YPP339tEwJeGZP3DlbWId7XQzSUII4RUjKLIHCVEHChba4PIxzwUoklNEUBDVWl/ACZvF23IgKJHrgotD66mCNTWeZDb3wUk/cWFT8Uvx+aloEslHBCFkUgR8+u9w/jETJg77OrMKoaPAytLXVUch0w4lJjVQmyqgm3p2g6kdQw4VWoF6RymG7vkvIaxG5FyZp8hSQSOkXJ5YbB5cE3P0Vx7XYSn761FQdO5mFvWVKJr8/+y+fb1yzG93/2YFG5n9f7Qaoh0+8tIhCuwuhIkqYSGWBaRQ241BXHzseXUjYE8U93nKqXDYk8j4R8lKoCR8Odl/lkvLdnA2rCAW5AD9WUmfZWfGUwB+5QShIZn2r7rigELuSH9j2NkYyGobSG5bXBGXVHMjpVzyyu9iTx1ZlrvGZMJw51yERvFEpJqDgHeMMQHIqljVDAwz270pPA4HAOMXfQYbGx+cBwFrphzak6qqlBXhtc3kiWVbwTrl1ZQ71dwGenO3H0/M2HblCOZWJ0KA7ZV0IOFamEBdnSUs9T8cxfPZhNdy6STfQR99xbEuOISrZZvI43RUrBKPcP7XtmzoccPPE3jk+DlkX5r2dHIXtd721CwzVgFg58cfoSWtc2QZxyo5lZegdSmLIveZvh3nvhuGWYp6jLAbM4rGc6uvmQqDuas/ClmI6RoRQmj0U5Tz6i9lg7nkNc33l1I7avX4L2327io8MX5q3j0HU9l0pQEyLo+f/7Z4o2sbLYYJSG29Yt4Yzdvn4pz+H56qjJPqr7ChFPzHtPBhSGey1HsaHpBk79ep2H7MS5KK/v89Ex1TQMVSXS51k/+V1h1a4DhhuKWW+5lAmz9Y2pOg7UxC0IdENmRL6pV3OYEq3dIsYum80Acw4lYLKOmU3AXWKCxLsnj9H4tsRYr0j39+O2+3m20MPUoWeG6f6Qv3iMj3thyIpyjK7r3v1aNrObFhb060hPDVBgPbzlOs7U0AmiOOgJlOyniiAMBILB5+g3tlDeW1oalqFTyPOHT/acZDAQCr1Av3dZ7dqXXWv6FZ/3S9IWiA8ReqmU5gyFuM11uOmnE+uzI1RwvGTAuG8AQTAYY910Jfs8EArvZkyOusv/CTAAht0nYPLRc7YAAAAASUVORK5CYII=</Image>
> +<Url type="text/html" method="GET" template="http://m.market.yandex.ua/search.xml">
> +  <Param name="text" value="{searchTerms}"/>
> +  <Param name="from" value="os"/>

Any specific reason for this parameter? I don't see it anywhere in the main search page, so not sure it's necessary (for both mobile and desktop version).

@@ +11,5 @@
> +<Url type="application/x-moz-tabletsearch" method="GET" template="http://market.yandex.ua/search.xml">
> +  <Param name="text" value="{searchTerms}"/>
> +  <Param name="from" value="os"/>
> +</Url>
> +</SearchPlugin>

You're missing <SearchForm>URL</SearchForm>.
Attachment #799064 - Flags: review-
(Assignee)

Comment 17

4 years ago
Created attachment 799475 [details] [diff] [review]
Added search form

<Param name="from" value="os"/> was taken from their existing OpenSearch plugin, see comment #8
Attachment #799064 - Attachment is obsolete: true
Attachment #799475 - Flags: review?(francesco.lodolo)
Comment on attachment 799475 [details] [diff] [review]
Added search form

Review of attachment 799475 [details] [diff] [review]:
-----------------------------------------------------------------

Patch is good for me. For yandex-market.xml icon is displayed correctly and search is working as expected (phone -> mobile, tablet -> full version).

Test URL: http://flod.org/testsp

Since I'm still new at productization bugs please wait for Axel's feedback before committing this patch. 

If feedback is positive, when you commit remember to keep a reference to this bug and reviews/feedbacks received (e.g. "Bug 891054: [uk] Search engine setup for Firefox Mobile for Ukranian, r=flod, f=pike").
Attachment #799475 - Flags: review?(francesco.lodolo)
Attachment #799475 - Flags: review+
Attachment #799475 - Flags: feedback?(l10n)

Updated

4 years ago
Attachment #799475 - Flags: feedback?(l10n) → feedback+
(Assignee)

Comment 19

4 years ago
Committed.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/uk/rev/0777d0b51695
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
OS: Mac OS X → All
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.