In 2.19 the keystrokes of shift-cmd-p do not enable spell check

RESOLVED FIXED in seamonkey2.22

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: reed1003, Assigned: neil)

Tracking

({late-l10n, regression})

SeaMonkey 2.17 Branch
seamonkey2.22
x86
macOS
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.19 wontfix, seamonkey2.20 fixed, seamonkey2.21 fixed, seamonkey2.22 fixed)

Details

Attachments

(1 attachment)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:20.0) Gecko/20100101 Firefox/20.0 SeaMonkey/2.17.1 (Beta/Release)
Build ID: 20130410205209

Steps to reproduce:

shift-cmd-p do not work for spell check in version 2.19


Actual results:

nothing


Expected results:

spell checking
What is in Error Console? Expecting dupe for Bug 887010
The command opens up a browser window with a reference to private browsing.
Probably caused by Bug 837510 Add File - New - Private Window menuitem

It looks like cmd-shift-P is now supposed to open a private browsing window.
Blocks: 837510
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
This is a classic case of hotkey collision. Hopefully "Check spelling" was moved to another hotkey but I don't know which one. (Private browsing is a recent invention.)

Ctrl+Shift+P is "New → Private Browsing Window" on Linux also. I don't see any hotkey mentioned for the various spell-related menuitems.

Mozilla/5.0 (X11; Linux i686 on x86_64; rv:25.0) Gecko/20100101 Firefox/25.0 SeaMonkey/2.22a1 ID:20130709003001 c-c:c1021b0b890c m-c:f2de2035f0af
Boy, I'd sure like a keystroke feature for spell check.  Been using keystrokes for many tasks for years.
(In reply to reed1003 from comment #5)
> Boy, I'd sure like a keystroke feature for spell check.  Been using
> keystrokes for many tasks for years.

It seems you are ripe for the keyconfig extension. That extension is not found at AMO, but you can get the latest version from the first link at http://forums.mozillazine.org/viewtopic.php?t=72994&f=48 which is also a mutual-help forum about defining keys for whatever you want them to do (if possible).
(In reply to Tony Mechelynck from comment #4)
> This is a classic case of hotkey collision. Hopefully "Check spelling" was
> moved to another hotkey but I don't know which one. (Private browsing is a
> recent invention.)

No, it wasn't, and it needs to be, I suppose. Accel+Shift+S is used by Publish, but we could move that to Accel+Shift+H perhaps, unless someone else has any other preference?
Flags: needinfo?(mnyromyr)
Ah, so the key is shared with Thunderbird, so it's not easily changeable. I guess we have to change the Private Browsing key instead, which is a shame, because it's the key Firefox uses...
Looking at what other browsers do (haven't verifyed myself, just did some quick search):

IE and Firefox: accel+Shift+P
Chrome and Opera: accel+Shift+N

So one option would be to use accel+Shift+N which would in some way be more logical if you look at what the non-shift key combo is.
(In reply to Stefan [:stefanh] from comment #9)
> Looking at what other browsers do (haven't verifyed myself, just did some
> quick search):
> 
> IE and Firefox: accel+Shift+P
> Chrome and Opera: accel+Shift+N

Forgot to menation that Safari doesn't seem to have a shortcut for this...
Oops, Accel+Shift+N is New Composer Page
Consensus seems to be to change the key to Ctrl+Shift+B instead.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #774329 - Flags: review?(philip.chee)
Flags: needinfo?(mnyromyr)
Comment on attachment 774329 [details] [diff] [review]
Possible patch

r=me for CTRL-SHIFT-B
Attachment #774329 - Flags: review?(philip.chee) → review+
Pushed comm-central changeset d7237cd27263.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.22
Comment on attachment 774329 [details] [diff] [review]
Possible patch

[Approval Request Comment]
Regression caused by (bug #): 837510
User impact if declined: Advertised spellcheck keyboard shortcut doesn't work
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low, Private Browsing is a new feature so hopefully nobody will mind that the key changes
String changes made by this patch: One command key
Attachment #774329 - Flags: approval-comm-beta?
Attachment #774329 - Flags: approval-comm-aurora?
Comment on attachment 774329 [details] [diff] [review]
Possible patch

a=me assuming l10n notification is made
Attachment #774329 - Flags: approval-comm-aurora? → approval-comm-aurora+
(In reply to Ian Neal from comment #16)
> Comment on attachment 774329 [details] [diff] [review]
> Possible patch
> 
> a=me assuming l10n notification is made

adding late-l10n keyword for anyone who follows that. Thread is at https://groups.google.com/d/msg/mozilla.dev.l10n/jA2CLqUuN8c/4JwpmUIa6wYJ
Keywords: late-l10n
Comment on attachment 774329 [details] [diff] [review]
Possible patch

Review of attachment 774329 [details] [diff] [review]:
-----------------------------------------------------------------

a-beta=me a-CLOSED_TREE=me
Attachment #774329 - Flags: approval-comm-beta? → approval-comm-beta+
Blocks: 897233
You need to log in before you can comment on or make changes to this bug.