Closed
Bug 897233
Opened 11 years ago
Closed 11 years ago
Change keyboard shortcut and correct typo in Help for Private Browsing feature
Categories
(SeaMonkey :: Help Documentation, defect)
SeaMonkey
Help Documentation
Tracking
(seamonkey2.20 unaffected, seamonkey2.21 fixed, seamonkey2.22 fixed)
RESOLVED
FIXED
seamonkey2.22
| Tracking | Status | |
|---|---|---|
| seamonkey2.20 | --- | unaffected |
| seamonkey2.21 | --- | fixed |
| seamonkey2.22 | --- | fixed |
People
(Reporter: rsx11m.pub, Assigned: rsx11m.pub)
References
Details
Attachments
(1 file)
|
2.17 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
(Quoting Ian Neal from bug 872000 comment #30) > Now that the command key has been set to B rather than P the > shortcuts_navigator.xhtml needs to be fixed (bug 891081) (Quoting Ian Neal from bug 872000 comment #31) > >+ <li>Saved Form and Search History will be available to a private window, > >+ thus providing suggestions for from fields or searches. However, any > Should this be "form" instead of "from"?
Both issues addressed.
Attachment #780020 -
Flags: review?(iann_bugzilla)
Attachment #780020 -
Flags: review?(iann_bugzilla) → review+
Comment on attachment 780020 [details] [diff] [review] Proposed patch [Triage Comment] a=me for comm-aurora
Attachment #780020 -
Flags: approval-comm-aurora+
Thanks Ian, push for comm-central and comm-aurora please whenever possible.
status-seamonkey2.20:
--- → unaffected
status-seamonkey2.21:
--- → affected
status-seamonkey2.22:
--- → affected
Keywords: checkin-needed
Whiteboard: [c-n: comm-central, comm-aurora]
Callek, can this patch land on c-c and c-a? This affects Help contents only, thus won't break any functionality for sure.
Flags: needinfo?(bugspam.Callek)
(In reply to rsx11m from comment #4) > Callek, can this patch land on c-c and c-a? > > This affects Help contents only, thus won't break any functionality for sure. Shouldn't be a problem landing on c-a
Thanks, redirecting needinfo? to RyanVM for checkin on closed tree (can land with DONTBUILD).
Flags: needinfo?(bugspam.Callek) → needinfo?(ryanvm)
|
||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/be3215e22270 https://hg.mozilla.org/releases/comm-aurora/rev/bb74f1e553c3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central, comm-aurora]
Target Milestone: --- → seamonkey2.22
You need to log in
before you can comment on or make changes to this bug.
Description
•