891202 - [Bluetooth][OPP cleanup] Unify obex data sending function

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

- Unify obex data sending function for simplicity
- Correct typos in comment

Comment 1

[Ben Tian (inactive)]

Attachment: Patch 1: v1: Unify obex data sending function

Changes:
- Unify obex data sending function for simplicity
- Replace mLastCommand with mIsServer to decide server/client data handler
- Correct typos in comment

Comment 2

[Ben Tian (inactive)]

Attachment: Patch 1: v2: Unify obex data sending function

Remove redundant newline.

Comment 3

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 772526 [details] [diff] [review]
Patch 1: v2: Unify obex data sending function

Review of attachment 772526 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed. Thanks for cleaning up!

::: dom/bluetooth/BluetoothOppManager.cpp
@@ +971,2 @@
>    }
> +  return;

Extra return

@@ +1163,5 @@
> +}
> +
> +void
> +BluetoothOppManager::SendObexData(uint8_t* aData,
> +                                  uint8_t aOpcode,

Less than 80 characters, no need to wrap.

::: dom/bluetooth/BluetoothOppManager.h
@@ +45,5 @@
>    void ClientDataHandler(mozilla::ipc::UnixSocketRawData* aMessage);
>    void ServerDataHandler(mozilla::ipc::UnixSocketRawData* aMessage);
>  
>    /*
> +   * If a application wants to send a file, first, it needs to

super-nit: If 'an' application

Comment 4

[Ben Tian (inactive)]

Attachment: [final] Patch 1: v3: Unify obex data sending function, r=echou

Fix nits.

Comment 5

[Ben Tian (inactive)]

try server: https://tbpl.mozilla.org/?tree=Try&rev=241da6947030

Comment 6

[Ben Tian (inactive)]

try again to cover all build:
https://tbpl.mozilla.org/?tree=Try&rev=c40eaa95bebd

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

http://hg.mozilla.org/projects/birch/rev/82e61abf9cd1

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/82e61abf9cd1