891235 - WebSMS: remove navigator.mozSms

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

We should have only navigator.mozMobileMessage from now on.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: WIP

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=d516adace020

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 773887 [details] [diff] [review]
patch

Review of attachment 773887 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Though, some changes might no longer apply with the recent Navigator's WebIDL conversion.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch : v2

Rebase. https://tbpl.mozilla.org/?tree=Try&rev=3d9a65d66d2f

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch : v3

fix Mn bustage.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/projects/birch/rev/5ce6a2000fa3

Comment 7

[Ed Morley [:emorley]]

Backed out for failures in test_getthreads.js:
https://tbpl.mozilla.org/php/getParsedLog.php?id=25645979&tree=Birch

https://hg.mozilla.org/projects/birch/rev/483f3f62f092

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Attachment: bug-891235.patch

Picked wrong patch file.

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/projects/birch/rev/5512e76c7a26

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5512e76c7a26

Comment 11

[Kohei Yoshino]

https://developer.mozilla.org/en-US/docs/Web/API/MozSmsManager
https://developer.mozilla.org/en-US/docs/Web/API/window.navigator.mozSms
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility

Comment 12

[Kohei Yoshino]

Removed this bug from the site compat doc. My false positive.