Closed
Bug 891276
Opened 11 years ago
Closed 11 years ago
[Bluetooth] Cleanup AddServiceRecords
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
(Whiteboard: [fixed-in-birch])
Attachments
(2 files)
|
2.88 KB,
patch
|
echou
:
review+
|
Details | Diff | Splinter Review |
|
1.80 KB,
patch
|
echou
:
review+
|
Details | Diff | Splinter Review |
and cleanup dbus_returns_uint32 as discussed on bug 884840.
|
Assignee | |
Comment 1•11 years ago
|
||
It's not used anywhere. Lets remove it.
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Summary: [Bluetooth] Replace AddServiceRecords by non-blocking implementation → [Bluetooth] Cleanup AddServiceRecords
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #773251 -
Flags: review?(echou)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #773253 -
Flags: review?(echou)
|
||
Updated•11 years ago
|
Attachment #773251 -
Flags: review?(echou) → review+
|
|
||
Updated•11 years ago
|
Attachment #773253 -
Flags: review?(echou) → review+
|
|
||
Comment 4•11 years ago
|
||
Thanks for cleaning up! There is only one thing I would like to mention: the summary of patch 2 is not totally correct since you actually removed dbus_returns_uint32 but not dbus_returns_int32. ;)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Oops, typo. I'll fix that for the actual commit. Thanks for your review. :)
|
|
Assignee | |
Comment 6•11 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/a1b370105e04
https://hg.mozilla.org/projects/birch/rev/e8fe3e9edb4e
Whiteboard: [fixed-in-birch]
|
||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a1b370105e04
https://hg.mozilla.org/mozilla-central/rev/e8fe3e9edb4e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•