853550 - [Bluetooth] Remove DBus/Bluetooth command thread

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

To simplify the Bluetooth system and save some resources we want to remove the command thread for Bluetooth/DBus. This thread is currently necessary because we have calls to DBus, which we cannot execute from within the main thread because they are blocking. Once bug 830290 landed, we have the infrastructure to convert all remaining blocking DBus calls to asyncronous calls. This will allow us to remove the need for the command thread.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I think that removing the command thread will be a long-term process.

Currently, several operations are blocking only. This includes methods outside of the DBus/BlueZ code, such as BluetoothHFPManager::Connect. If we want to convert this code to be non-blocking, we'll need to redesign the way this code works.

I think we should start by changing the BlueZ code to be more non-blocking and do most processing in the call back functions of the replies. Once we have this in place we can work 'outwards' to the calling code.

This bug should be the meta-bug for all related changes.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 853550: Fix whitespace errors

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 853550: Cleanup DBus thread handling

I turned Bluetooth on and off several dozen times in a row to test this change.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 853550: Replace Bluetooth command thread

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 798432 [details] [diff] [review]
[03] Bug 853550: Replace Bluetooth command thread

Review of attachment 798432 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks :)

Comment 6

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 798432 [details] [diff] [review]
[03] Bug 853550: Replace Bluetooth command thread

Review of attachment 798432 [details] [diff] [review]:
-----------------------------------------------------------------

You did it! Thanks for solving a series of bugs and making the codebase cleaner! :)

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Take this, command thread!

https://hg.mozilla.org/integration/b2g-inbound/rev/8ad04b673163
https://hg.mozilla.org/integration/b2g-inbound/rev/50e6aad45b40
https://hg.mozilla.org/integration/b2g-inbound/rev/9d22ff450bfd

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=9d22ff450bfd

Thanks everyone for the reviews. :)

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8ad04b673163
https://hg.mozilla.org/mozilla-central/rev/50e6aad45b40
https://hg.mozilla.org/mozilla-central/rev/9d22ff450bfd