891345 - [User Story][Settings] Need an UI for calling line identification restriction

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

We need some bit in gaia for adding support for calling line identification restriction in the setting app. It could be ideally in the setting app under the call settings.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

We need the input from our UX friends, adding ni?.

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Screenshot 1

Screenshot 1 proposal

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Screenshot 2

Screenshot 2 proposal

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Screenshot 3

Screenshot 3

Comment 5

[Al Tsai [:atsai]]

I'll leave the in-moztrap? here and write some test case for it after the UX pages are confirmed.

Comment 6

[Anshul]

Jose, is there a need for such a setting in the UI as this is not a very used feature and also because there is an MMI code to do that already supported by commercial RIL and soon to be supported by Moz RIL.

Comment 7

[Antonio Manuel Amaya Calvo (:amac)]

So long as this doesn't take much work, I think there's no harm in easing the users life. Maybe the feature isn't very used because there's no UI for it :).

Comment 8

[Stephany Wilkes]

Clearing the team needinfo and assigning to Neo since Settings is his domain. Neo, please evaluate whether or not you believe the suggested UI is needed here.

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

IMHO there is a need for such setting. Android has this UI and other OSs. I would say people usually don't know about a MMI code (even about MMI codes in general) for enabling/disabling calling line identification restriction feature. We are planning to add that support through MMI code in the reference RIL implementation as well but first let user handle the feature through the setting app.

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/10927

WIP. Need to get r+ in bug 888904 before requesting review here. We still need the UX team input here.

Comment 11

[Al Tsai [:atsai]]

MozTrap #9013, #9014

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 773947 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/10927

Arthur, this PR adds a simple UI for allowing the user to show or hide the caller Id for outgoing calls. The UX input is still pending but I guess it won't change too much from how it is designed. Could you take a look please? Thanks!

Comment 13

[Neo Hsieh [:neo]]

Attachment: Call Settings.xlsx

Hi, I think some of the structures has to modify. Please check attached file.

Comment 14

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Neo Hsieh from comment #13)
> Created attachment 779054 [details]
> Call Settings.xlsx
> 
> Hi, I think some of the structures has to modify. Please check attached file.

Hey Neo, are you suggesting to change the whole call settings structure? If so, IMHO we should file another bug to deal with this big change and land the work in this bug after landing the change. Moreover the feedback that you've provided is a bit difficult to understand (it includes even panel layout not existing yet) and prone to misunderstandings. Could you please provide some wire frames instead? Thanks.

Comment 15

[Neo Hsieh [:neo]]

Yes. Because we will have more and more settings add into "Call settings" in the future. I think it's time to optimize the structure. So as you can see, I changed the structure. 
You are right. I need to create another bug to do this.  


About the feedback bug,Please see also this 
bug 851189

Comment 16

[Neo Hsieh [:neo]]

In caller ID part. I think that is better to reduce one level.  I mean, You can jump screenshot 2. 
(Screenshot 1 (Caller ID) --> Screenshot 3 (Select))

Comment 17

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Neo Hsieh from comment #15)
> Yes. Because we will have more and more settings add into "Call settings" in
> the future. I think it's time to optimize the structure. So as you can see,
> I changed the structure. 
> You are right. I need to create another bug to do this.  

The question is, Must we do this UI refactor before including Caller ID settings?

Comment 18

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Neo Hsieh from comment #16)
> In caller ID part. I think that is better to reduce one level.  I mean, You
> can jump screenshot 2. 
> (Screenshot 1 (Caller ID) --> Screenshot 3 (Select))

If we do what you suggest we would delete the button in the screenshot #2, that way we change how the rest of select inputs are used in Gaia (with this button I mean). Is that what you suggest?

Comment 19

[Wilfred Mathanaraj [:WDM]]

Having had a read of this conversation I have to agree with Noemi that we need to split the "re-doing call settings structure" into a different bug - 
this new bug should then be added to the nice to have list of the backlog for us to pick from once we have done all items that must be completed for v1.2.

891345 should continue to focus on adding caller ID settings.

Comment 20

[Arthur Chen [:arthurcc][inactive after 6/30]]

Jose, we have similar UI in the settings app. Please refer to the changing language select in the Language panel.

Comment 21

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Screenshot 4

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #18)
> (In reply to Neo Hsieh from comment #16)
> > In caller ID part. I think that is better to reduce one level.  I mean, You
> > can jump screenshot 2. 
> > (Screenshot 1 (Caller ID) --> Screenshot 3 (Select))
> 
> If we do what you suggest we would delete the button in the screenshot #2,
> that way we change how the rest of select inputs are used in Gaia (with this
> button I mean). Is that what you suggest?

Neo, here is a picture that shows how the caller Id item looks. Is that what you want? Thanks.

Comment 22

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Arthur Chen [:arthurcc] from comment #20)
> Jose, we have similar UI in the settings app. Please refer to the changing
> language select in the Language panel.

Arthur, I've updated the code in the PR. I guess it's ready for the review. Could you take a look at it please? Thanks!

Comment 23

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 773947 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/10927

Thank you for the effort, Jose! r=me with comments addressed.

Comment 24

[Neo Hsieh [:neo]]

Yes, Thank you. Looks great.

Comment 25

[José Antonio Olivera Ortega [:jaoo]]

Thanks Arthur and Neo!

https://github.com/mozilla-b2g/gaia/commit/c0265432b75c1586bbe0d5fd7366c680951404d6

Comment 26

[rafael.marquez]

The user story has been tested with satisfactory results. 

The tests have been executed with a SIM Tuenti. We tested several movistar SIMS, but we could not activating you supplementary services to this type of SIM.