891664 - Defect - Unable to flip remember password pref

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Flyouts, defect, P1)

Description

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

Remember password on preferences flyout does not toggle when clicked/touched. Jimm noted this on Bug 890771.

This was happening because the throbber container for private data pref (#clearprivacythrobber) was not taking the set width/height and was larger then expected, running over the toggle. Had to keep current width/height properties to make the throbber have the correct size AND set max-width/height to make the XUL container have the correct size.

p=1.

Comment 1

[Jim Mathies [:jimm]]

Comment on attachment 773008 [details] [diff] [review]
Patch v1

Ah, my bad. Thanks.

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d1c7df361ba

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2d1c7df361ba

Comment 4

[Samvedana (:Samvedana)]

User Agent : Mozilla/5.0 (Windows NT 6.2; WOW64; rv:25.0) Gecko/20130712 Firefox/25.0
Build ID: 20130712030203

I can not reproduce this issue on latest nightly from ftp://ftp.mozilla.org/pub/firefox/nightly/2013/07/2013-07-12-03-02-03-mozilla-central/

Metro Firefox asked me to remember password.
I can change setting using "Remember Passwords" toggle button.

Comment 5

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #12 without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-15-03-02-03-mozilla-central/

- Went through the original test case in comment #0 without any issues
- Toggled the "Remember Passwords" several times without any issues
- Ensured that when "Remember Passwords" is toggled "Off", websites don't prompt the user to save the password
- Ensured that when "Remember Passwords" is toggled "On", websites ask the user to either "Remember passwords" & "Not for this site"
- Ensured that the passwords are saved correctly when the user selects "Remember password"
- Went through all of the above test cases in Filled View without any issues

I ran into some preference inconsistencies while going through this, will add more information in bug 899528