891742 - [B2G][Gaia] Set and Query the roaming preference setting in Gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Ken Chang[:kenkai]]

It's necessary to allow user to select roaming mode (home only, roaming only or any) in setting app.

Comment 1

[Enpei]

Hi Ken,

What is the purpose of "roaming only" option?

Thanks,
Enpei

Comment 2

[Enpei]

I mean does it mean that device can't camp on home network when this item is selected?

Comment 3

[Edgar Chen [:edgar]]

(In reply to echu from comment #1)
> Hi Ken,
> 
> What is the purpose of "roaming only" option?
> 
> Thanks,
> Enpei

Correct the roaming mode we support:
1. home only.
2. roaming on affiliated networks.
3. roaming on any network.

I have did some test by switching between above 3 modes, but I did not see any different in my cdma device. I guess it is because device is in home network, and these will only affect device when it is in roaming.

Thanks

Comment 4

[Kai-Chih Hu [:khu]]

Ivan and Candice, can you help to make sure it's under your radar? Thanks.

Comment 5

[Enpei]

Hi Ken,

After the meeting with UX team on 7/22, are supported items still be following ones?
1. home only.
2. roaming on affiliated networks.
3. roaming on any network.

Thanks.

Comment 6

[Enpei]

Confirmed with Ken in agile meeting, 3 options unchanged.

Comment 7

[Ken Chang[:kenkai]]

Tim, is it possible to have someone from you team to implement this setting option?

Comment 8

[Ivan Tsay (:ITsay)]

I will check with Tim about the loading on the setting app and see if we have bandwidth on this.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Ken Chang from comment #7)
> Tim, is it possible to have someone from you team to implement this setting
> option?

Yes! Arthur, could you help or guide anyone in the office to solve the issue?

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

I'll take the bug and reassign it to appropriate members.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Related APIs for this bug are: 
- mobileConnection.setRoamingPreference
- mobileConnection.getRoamingPreference 

Possible values include:
- "home"       : disable roaming
- "roaming"    : enable roaming
- "affiliated" : enable roaming only with affiliated operators

The APIs are only for CDMA. Calling to the APIs on a GSM device always gets not support error.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

The possible values should be:

- "home"       : disable roaming
- "any"        : enable roaming
- "affiliated" : enable roaming only with affiliated operators

It should be "any" instead of "roaming".

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/11374

In this patch it gets the current network type based on the json file. We assumes that the device does not support gsm and cdma at the same time. And it initializes the corresponding selector based on the network type. 

Jose, could you help review the patch? Thanks!

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: network.json

Put network.json to GAIA_DIR/distribution and make reset-gaia to have a build for CDMA.

Comment 15

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 786217 [details]
link to https://github.com/mozilla-b2g/gaia/pull/11374

I left a couple of comments on github but nothing important. Looks good, works well. I guess you will run into merge conflicts when landing bug 881862 after this one. Thanks Arthur!

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment addressed, thanks for reviewing, Antonio! I also modified the code a little bit to address the need of showing all network modes by default.

master: https://github.com/mozilla-b2g/gaia/commit/20d43f63870098952b430d9e303b8309d206e059

Comment 17

[Enpei]

Hi Ken,

Since there is no further information about how non-affiliated network should be implemented, should it be removed from the setting?

Comment 18

[Ken Chang[:kenkai]]

Enpei, Sure. I will fire another bug for removing "non-affiliated".