891798 - [KeyBoard] Home screen appears when suggestion bar hides while changing focus from one text field to another.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Description

[Leo]

Title : Home screen appears when suggestion bar hides while changing focus from one text field to another.

STR for Master Gaia
====================

1. Open Browser >> Bookmark one websit
2. Edit Bookmark
3. Focus "Page Title" Textfield 
4. Switch focus to "ADDRESS" textfield

The Home screen flickers for a moment when word suggestion Hides.

Comment 1

[Leo]

This is a follow up for bug 863680.

Comment 2

[Leo]

Attachment: Patch for word Suggestion Hides without Home screen

Hi Rudy, 
Can you Please review this attached patch.

Thank you.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 773334 [details] [diff] [review]
Patch for word Suggestion Hides without Home screen

Review of attachment 773334 [details] [diff] [review]:
-----------------------------------------------------------------

From my point of view, this patch simply makes us always do: 
  1. update the window height via changing the hash of keyboard url
  2. Render the keyboard itself

From my test, this issue would only occur on browser app and homescreen app. and in these cases, we would receive 2 onfocuschange events.
And we will do renderKeyboard() twice, which would trigger the reset of candidatePanelEnabled flag.

That's why when this patch always keep candidatePanelEnabled as true, we can workaround this issue.
While we are still not sure of the root cause of the "2 onfocuschange events", 
I would recommend we get rid of the candidatePanelEnabled flag approach, do the above step 1 and step 2 all the time.

--
I'll clear the review flag.
Please reset it if you have an updated patch. Thanks.

Comment 4

[Leo]

Thanks Rudy for review,
I observed there is more than one "onfocuschang event" which calls
render keyboard more than once which is the root cause.
I am not sure about root cause of "2 onfocuschange event"

Rudy, can you please look into this issue.
Assigning it to Rudy.

Comment 5

[Leo]

Attachment: Patch for word Suggestion Hides without Home screen

Hi Rudy,
I have made workaround for multiple focus problem.
Please review it and if its require changes,then please
make a patch to solve this issue.

Thank you

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

leo you're still the assignee.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 775527 [details] [diff] [review]
Patch for word Suggestion Hides without Home screen

Review of attachment 775527 [details] [diff] [review]:
-----------------------------------------------------------------

I think this approach did not consider the case that when we switch from one input to another input with the same type and inputmode.
(and the "states", such as its input value, might be different)

I am going to steal this bug and provide a patch to workaround the duplicate focuschange events.

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1 - pull request 10977

Hi Jan,

Could you help review this patch to workaround Bug 893755?

[Root Cause]
The original code would do:
 1. When the candidate panel is not needed and it was shown with last keyboard layout, notify keyboard manager first (for window resize) and then redraw the keyboard.
 
However, with duplicate onfocuschange, this logic cannot work:

 1. 1st onfocuschange after switching the focus to an input which doesn't need suggestion 
    1.a As the original design goes, will delay the keyboard drawing 
    1.b candidatePanelEnabled will be changed false.  

 2. the (buggy) 2nd onfocuschange comes,
    2.a candidatePanelEnabled is false, so it will redraw the keyboard immediately, which happened earlier than 1.a
      => caused the issue

[Workaround]
1. Always do the delay when
 - No need to show candidate panel
 - The keyboard has been shown

Thanks.

Comment 9

[Jan Jongboom [:janjongboom] (inactive)]

I can still reproduce this (b0bc257a26d9b6660af519658baad0928496713c). Flashed gaia to my GP Keon, go into edit bookmarks and start tapping both inputs very fast (one after another). There are still cases where the resizing is not in sync..

Comment 10

[Jan Jongboom [:janjongboom] (inactive)]

I think it might be caused when you have 2 render actions that happen right after each other or something.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 775626 [details]
Patch V1 - pull request 10977

Hi Jan,

Thanks for finding out this case.
I just updated the patch trying to address this issue.

Could you please review it again?
(the 2nd commit, will squash them if it got r+)

Comment 12

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 775626 [details]
Patch V1 - pull request 10977

If you go completely bezerk it might take 1-2 seconds for the right keyboard to pop up but that's something else, probably CPU bound with the way we do rendering, but the homescreen never shows anymore. r=janjongboom

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
acf2693cb24fbb3eb1185ee2a9f612e71870f047

v1-train,
fb9362d34260771d4a00b9a0e10a6bbad397bd3b

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: fb9362d34260771d4a00b9a0e10a6bbad397bd3b