891859 - buildmaster toplevel stuff needs TLC

Status: RESOLVED WONTFIX

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

The toplevel says "include buildmaster" but buildmaster/manifests/init.pp is empty.  Also, what's up with buildmaster::buildbot_master::?

We should divide out the different types of masters a little bit better.

The per-host config that's currently in the node defs should move to the toplevel class, similar to the approach in toplevel::server::signing.  And that's only until we find a way to parse production-masters.json easily.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

So a few points here:
 * the toplevel classes are toplevel::server::buildmaster and toplevel::server::buildmaster::servo, which is odd, since they really should be peer classes
 * buildmaster::buildbot_master??
 * lots of buildmasters have extra bits, either toplevel classes or regular classes, added on now - selfserve_agent, releaserunner, db_maintenance, gaia_bumper, etc.  Those should be handled more smoothly.
 * per-master config is included in each node definition, redundant to that in production-masters.json (bug 848824).

The per-master config can be handled with the extsync support in bug 931056.  The extra bits can be handled as aspects.

Comment 3

[Amy Rich [:arr] [:arich]]

We're not likely to get around to this before stopping the use of buildbot all together.