Closed
Bug 892012
Opened 11 years ago
Closed 11 years ago
Localize /tools and /me on webmaker.org
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alicoding, Assigned: alicoding)
References
Details
(Whiteboard: s=2013w29 p=1)
Attachments
(1 file)
Localize /tools and /me on webmaker.org
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → ali
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: wb.localization
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #773544 -
Flags: review?(schranz.m)
Attachment #773544 -
Flags: review?(david.humphrey)
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://github.com/mozilla/webmaker.org/pull/256#discussion_r5146635 https://github.com/mozilla/webmaker.org/pull/256#discussion-diff-5144834
Flags: needinfo?(pomax)
I've left some comments on both discussions. The markup-in-strings problem I think Atul ran into as well when he was adding transifex to friendlycode. Did you ask him what he ended up doing and why?
Flags: needinfo?(pomax)
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: wb.localization → s=2013w29 p=1
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 773544 [details] [review] https://github.com/mozilla/webmaker.org/pull/256 This one should be review after bug#889322
Attachment #773544 -
Flags: review?(schranz.m)
Attachment #773544 -
Flags: review?(pomax)
Attachment #773544 -
Flags: review?(david.humphrey)
Comment on attachment 773544 [details] [review] https://github.com/mozilla/webmaker.org/pull/256 looks close to good, still a few questions.
Attachment #773544 -
Flags: review?(pomax) → review-
|
|
Assignee | |
Updated•11 years ago
|
Attachment #773544 -
Flags: review- → review?(pomax)
Comment on attachment 773544 [details] [review] https://github.com/mozilla/webmaker.org/pull/256 looks good. One question, but no need for rereview.
Attachment #773544 -
Flags: review?(pomax) → review+
|
||
Comment 7•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/d97cebbc738af5216a176cd8ecf9534337fc2f7d bug892012 - Localized /me and /tools
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•