892224 - Defect - find bar not dismissed with ESC key

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[juan becerra [:juanb]]

Tested on 2013-07-10 using latest nightly.

I was trying to verify bug 879631 and I started by testing that bug 879115 (being able to dismiss the find bar) was still working as expected, but I noticed that the ESC key would not dismiss the find bar.

Steps:
1. Open Firefox Metro and go the About Us bookmark in the start page
2. Swipe up from the bottom to bring up the navigation bar and click on the rightmost icon and select "Find in Page"
3. Press the ESC key

Expected: The find bar should be dismissed.

Actual: The find bar is not dismissed.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Just a little thing we missed in bug 879631.

Comment 2

[Jonathan Wilde [:jwilde]]

Comment on attachment 774028 [details] [diff] [review]
patch

Review of attachment 774028 [details] [diff] [review]:
-----------------------------------------------------------------

:D

At some point, we should probably write tests for escape behavior since it seems like we regress this pretty regularly (I've seen two bugs so far during my internship on this).

Comment 3

[Matt Brubeck (:mbrubeck)]

Thanks for reminding me about the tests. I'll work on that next.

https://hg.mozilla.org/integration/mozilla-inbound/rev/13a4454a0a6c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/13a4454a0a6c

Comment 5

[Cornel Ionce [:noni]]

Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130715 Firefox/25.0

Verified as fixed on the latest Nightly build using the steps from the description. The find bar is now dismissed when pressing the ESC key.

Comment 7

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #13 testing without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-05-03-02-06-mozilla-central/

- Went through the original test case in comment #0 without any issues
- Retrieved the "Find in page" app bar by selecting the "Settings -> Find in Page" in the navigation app bar and then pressed "ESC". The "find in page" bar dismissed without any issues
- Retrieved the "Find in page" app bar by pressing "CTRL + F" and then pressed "ESC". The "find in page" bar dismissed without any issues
- Ensured that you can dismiss the "find in page" app bar using the "ESC" while there's text inside the search field
- Also went through the above test cases in filled & snapped view without any issues