892267 - Gray space at the top of content when opening a tab from an intent

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

Attachment: Screenshot of the issue

There is a grey bar about the size of the address bar when pages are loaded from external intents. I don't see this on FxA 24 or 25.

Comment 1

[Aaron Train [:aaronmt]]

Reproduced on Nightly (07/10) on my Nexus 4 (Android 4.2.2) using a t.co link off a Tweet. It doesn't persist, it flashes before rendering the content. I saw what you see in Kevin's screenshot.

Comment 2

[u421692]

The regression window is:

1.mozilla-central
good build: 04.07.2013 
bad build: 05.07.2013 
-pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dcbbfcdf7bb4&tochange=17fe59f6c54a

2.inbound
good build:1372942018
bad build: 1372943362
-pushlog: 
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0dbc3d79971d&tochange=efa23d6bd3fa

It seems that Bug 803207 caused this and also Bug 891175.

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

My comment 0 should say I don't see this on FxA 24 or 23.

Comment 4

[Aaron Train [:aaronmt]]

I see this also opening 'Apps' from the menu on my Galaxy S4 and Note II, maybe not specific to an intent here.

Comment 5

[Alex Keybl [:akeybl]]

Mostly cosmetic, so it wouldn't block, but still definitely worth tracking.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

I'm not sure what this scaleDiff is supposed to be doing. AFAIK all of these values are in screen pixels, so there should be no scaling involved. During startup I see mFrameMetrics.zoom go to 2.0 (on my N4) while the root layer resolution is still at 1.0. This causes scaleDiff to be 2.0 which causes the rendering to be offset by the height of the dynamic toolbar.

Comment 8

[Chris Lord [:cwiiis]]

Comment on attachment 782939 [details] [diff] [review]
Patch

Review of attachment 782939 [details] [diff] [review]:
-----------------------------------------------------------------

I'm assuming this wasn't always a problem piece of code, unless something changed underneath it... Does the background and shadow still line up when zooming in and out and so on? And text selection handles and auto-complete pop-ups appear in the right place? Assuming they do, LGTM I guess.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Yup, verified that all those things work as intended.

https://hg.mozilla.org/integration/mozilla-inbound/rev/50f69b500c02

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/50f69b500c02