Closed Bug 892833 Opened 7 years ago Closed 7 years ago

Enable mozTCPSocket in the desktop runtime

Categories

(Firefox Graveyard :: Webapp Runtime, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

No description provided.
Attached patch PatchSplinter Review
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Depends on: 892837
Attachment #774425 - Flags: review?(dpreston)
Comment on attachment 774425 [details] [diff] [review]
Patch

What are the security implications of this? Presumably normal webpages won't get access to this because they don't have the "tcp-socket" permission, but how do apps get this permission on desktop? Do apps that are installed from the marketplace on desktop that request the tcp-socket permission get it, just like on firefox os?
(In reply to Donovan Preston from comment #2)
> Comment on attachment 774425 [details] [diff] [review]
> Patch
> 
> What are the security implications of this? Presumably normal webpages won't
> get access to this because they don't have the "tcp-socket" permission, but
> how do apps get this permission on desktop? Do apps that are installed from
> the marketplace on desktop that request the tcp-socket permission get it,
> just like on firefox os?

Yes.
For Firefox desktop the API is still completely disabled (the pref change only affects the webapp runtime).
In the runtime, only apps that have the "tcp-socket" permission will be able to use the API.
The permission will be granted just like in Firefox OS (when bug 892837 lands).
Attachment #774425 - Flags: review?(dpreston) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bc494dcd45e4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.