Angle fails to build in VS 2013 ("error C2039: 'max' : is not a member of 'std'")

RESOLVED FIXED in mozilla29

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Xavier Fung, Assigned: emk)

Tracking

Trunk
mozilla29
x86
Windows 8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

4 years ago
Created attachment 774468 [details] [diff] [review]
Add missing include <algorithm> to make it build

Add missing include to make it build on VS 2013.
(Assignee)

Comment 1

4 years ago
BTW, why VS <= 2012 was able to compile without including <algorithm>?
(Reporter)

Comment 2

4 years ago
AFAIK this is a breaking change in VS 2013.
http://msdn.microsoft.com/en-us/library/vstudio/bb531344%28v=vs.120%29.aspx
(Reporter)

Comment 3

4 years ago
Also this block post stating that this is to conform with C++11.
http://blogs.msdn.com/b/vcblog/archive/2013/06/28/c-11-14-stl-features-fixes-and-breaking-changes-in-vs-2013.aspx
(Under Breaking Changes)
After merge https://codereview.appspot.com/12665047/, we should pick up that revision.

Updated

4 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Component: Build Config → Graphics

Updated

4 years ago
Attachment #774468 - Attachment is patch: true

Updated

4 years ago
Summary: Angle fails to build in VS 2013 → Angle fails to build in VS 2013 ("error C2039: 'max' : is not a member of 'std'")

Updated

4 years ago
Duplicate of this bug: 930616

Comment 6

4 years ago
HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH
"Mozilla tools directory: C:\mozilla-build\"
Visual C++ 11 directory: C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\
Visual C++ 12 directory: C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\
Windows SDK directory: C:\Program Files (x86)\Windows Kits\8.1\
Windows SDK version: 8.1
Using VC 2012 built-in SDK
Mozilla build environment: MSVC version 11.
Vlada@PC1 ~
$
HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH

C:\Program Files (x86)\Microsoft DirectX SDK (June 2010)\include\D3D11.h(918) : warning C4005: 'D3D11_ERROR_FILE_NOT_FOUND' : macro redefinition
        C:\Program Files (x86)\Windows Kits\8.1\include\shared\winerror.h(50388) : see previous definition of 'D3D11_ERROR_FILE_NOT_FOUND'
C:\Program Files (x86)\Microsoft DirectX SDK (June 2010)\include\D3D11.h(919) : warning C4005: 'D3D11_ERROR_TOO_MANY_UNIQUE_VIEW_OBJECTS' : macro redefinition
        C:\Program Files (x86)\Windows Kits\8.1\include\shared\winerror.h(50398) : see previous definition of 'D3D11_ERROR_TOO_MANY_UNIQUE_VIEW_OBJECTS'
C:\Program Files (x86)\Microsoft DirectX SDK (June 2010)\include\D3D11.h(920) : warning C4005: 'D3D11_ERROR_DEFERRED_CONTEXT_MAP_WITHOUT_INITIAL_DISCARD' : macro redefinition
        C:\Program Files (x86)\Windows Kits\8.1\include\shared\winerror.h(50407) : see previous definition of 'D3D11_ERROR_DEFERRED_CONTEXT_MAP_WITHOUT_INITIAL_DISCARD'
c:\program files (x86)\microsoft directx sdk (june 2010)\include\d3d10.h(608) : warning C4005: 'D3D10_ERROR_TOO_MANY_UNIQUE_STATE_OBJECTS' : macro redefinition
        C:\Program Files (x86)\Windows Kits\8.1\include\shared\winerror.h(50355) : see previous definition of 'D3D10_ERROR_TOO_MANY_UNIQUE_STATE_OBJECTS'
c:\program files (x86)\microsoft directx sdk (june 2010)\include\d3d10.h(609) : warning C4005: 'D3D10_ERROR_FILE_NOT_FOUND' : macro redefinition
        C:\Program Files (x86)\Windows Kits\8.1\include\shared\winerror.h(50364) : see previous definition of 'D3D10_ERROR_FILE_NOT_FOUND'
Config.obj
c:\Users\Vlada\comm-central\mozilla\config\rules.mk:1076:0$ mozbuild.action.cl main  cl -FoConfig.obj -c   -DLIBEGL_EXPORTS -DANGLE_BUILD -DNOMINMAX -D_CRT_SECURE_NO_DEPRECATE -D_SECURE_SCL=0 -DANGLE_DISABLE_TRACE -DANGLE_COMPILE_OPTIMIZATION_LEVEL=D3DCOMPILE_OPTIMIZATION_LEVEL1 -DNO_NSPR_10_SUPPORT -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include/KHR -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/.. -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../libGLESv2 -I"C:/Program Files (x86)/Microsoft DirectX SDK (June 2010)/include" -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL -I. -I../../../../dist/include  -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nspr -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nss       -MD            -EHsc  -EHsc  -EHsc -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -FS -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O2 -GR- -GS- -favor:AMD64 -arch:AVX -Oy  c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Config.cpp
Config.cpp
I have always this error (bug 930616)

c:\Users\Vlada\comm-central\mozilla\gfx\angle\src\libGLESv2/renderer/Renderer.h(27) : warning C4996: 'GetVersion': was declared deprecated
        C:\Program Files (x86)\Windows Kits\8.1\include\um\sysinfoapi.h(110) : see declaration of 'GetVersion'
c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Config.cpp(322) : warning C4267: '=' : conversion from 'size_t' to 'EGLint', possible loss of data
Display.obj
c:\Users\Vlada\comm-central\mozilla\config\rules.mk:1076:0$ mozbuild.action.cl main  cl -FoDisplay.obj -c   -DLIBEGL_EXPORTS -DANGLE_BUILD -DNOMINMAX -D_CRT_SECURE_NO_DEPRECATE -D_SECURE_SCL=0 -DANGLE_DISABLE_TRACE -DANGLE_COMPILE_OPTIMIZATION_LEVEL=D3DCOMPILE_OPTIMIZATION_LEVEL1 -DNO_NSPR_10_SUPPORT -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include/KHR -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/.. -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../libGLESv2 -I"C:/Program Files (x86)/Microsoft DirectX SDK (June 2010)/include" -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL -I. -I../../../../dist/include  -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nspr -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nss       -MD            -EHsc  -EHsc  -EHsc -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -FS -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O2 -GR- -GS- -favor:AMD64 -arch:AVX -Oy  c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Display.cpp
Display.cpp
c:\Users\Vlada\comm-central\mozilla\gfx\angle\src\libGLESv2/renderer/Renderer.h(27) : warning C4996: 'GetVersion': was declared deprecated
        C:\Program Files (x86)\Windows Kits\8.1\include\um\sysinfoapi.h(110) : see declaration of 'GetVersion'
libEGL.obj
c:\Users\Vlada\comm-central\mozilla\config\rules.mk:1076:0$ mozbuild.action.cl main  cl -FolibEGL.obj -c   -DLIBEGL_EXPORTS -DANGLE_BUILD -DNOMINMAX -D_CRT_SECURE_NO_DEPRECATE -D_SECURE_SCL=0 -DANGLE_DISABLE_TRACE -DANGLE_COMPILE_OPTIMIZATION_LEVEL=D3DCOMPILE_OPTIMIZATION_LEVEL1 -DNO_NSPR_10_SUPPORT -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include/KHR -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/.. -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../libGLESv2 -I"C:/Program Files (x86)/Microsoft DirectX SDK (June 2010)/include" -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL -I. -I../../../../dist/include  -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nspr -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nss       -MD            -EHsc  -EHsc  -EHsc -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -FS -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O2 -GR- -GS- -favor:AMD64 -arch:AVX -Oy  c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/libEGL.cpp
libEGL.cpp
c:\Users\Vlada\comm-central\mozilla\gfx\angle\src\libGLESv2/renderer/Renderer.h(27) : warning C4996: 'GetVersion': was declared deprecated
        C:\Program Files (x86)\Windows Kits\8.1\include\um\sysinfoapi.h(110) : see declaration of 'GetVersion'
main.obj
c:\Users\Vlada\comm-central\mozilla\config\rules.mk:1076:0$ mozbuild.action.cl main  cl -Fomain.obj -c   -DLIBEGL_EXPORTS -DANGLE_BUILD -DNOMINMAX -D_CRT_SECURE_NO_DEPRECATE -D_SECURE_SCL=0 -DANGLE_DISABLE_TRACE -DANGLE_COMPILE_OPTIMIZATION_LEVEL=D3DCOMPILE_OPTIMIZATION_LEVEL1 -DNO_NSPR_10_SUPPORT -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include/KHR -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/.. -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../libGLESv2 -I"C:/Program Files (x86)/Microsoft DirectX SDK (June 2010)/include" -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL -I. -I../../../../dist/include  -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nspr -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nss       -MD            -EHsc  -EHsc  -EHsc -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -FS -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O2 -GR- -GS- -favor:AMD64 -arch:AVX -Oy  c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/main.cpp
main.cpp
Surface.obj
c:\Users\Vlada\comm-central\mozilla\config\rules.mk:1076:0$ mozbuild.action.cl main  cl -FoSurface.obj -c   -DLIBEGL_EXPORTS -DANGLE_BUILD -DNOMINMAX -D_CRT_SECURE_NO_DEPRECATE -D_SECURE_SCL=0 -DANGLE_DISABLE_TRACE -DANGLE_COMPILE_OPTIMIZATION_LEVEL=D3DCOMPILE_OPTIMIZATION_LEVEL1 -DNO_NSPR_10_SUPPORT -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include/KHR -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/.. -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../libGLESv2 -I"C:/Program Files (x86)/Microsoft DirectX SDK (June 2010)/include" -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL -I. -I../../../../dist/include  -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nspr -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nss       -MD            -EHsc  -EHsc  -EHsc -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -FS -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O2 -GR- -GS- -favor:AMD64 -arch:AVX -Oy  c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Surface.cpp
Surface.cpp
c:\Users\Vlada\comm-central\mozilla\gfx\angle\src\libGLESv2/renderer/Renderer.h(27) : warning C4996: 'GetVersion': was declared deprecated
        C:\Program Files (x86)\Windows Kits\8.1\include\um\sysinfoapi.h(110) : see declaration of 'GetVersion'
c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Surface.cpp(378) : error C2039: 'max' : is not a member of 'std'
c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Surface.cpp(378) : error C3861: 'max': identifier not found
c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Surface.cpp(379) : error C2039: 'min' : is not a member of 'std'
c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Surface.cpp(379) : error C3861: 'min': identifier not found
Native command 'mozbuild.action.cl main' returned value '2'
c:\Users\Vlada\comm-central\mozilla\config\rules.mk:1076:0: command 'mozbuild.action.cl main  cl -FoSurface.obj -c   -DLIBEGL_EXPORTS -DANGLE_BUILD -DNOMINMAX -D_CRT_SECURE_NO_DEPRECATE -D_SECURE_SCL=0 -DANGLE_DISABLE_TRACE -DANGLE_COMPILE_OPTIMIZATION_LEVEL=D3DCOMPILE_OPTIMIZATION_LEVEL1 -DNO_NSPR_10_SUPPORT -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include/KHR -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/.. -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../libGLESv2 -I"C:/Program Files (x86)/Microsoft DirectX SDK (June 2010)/include" -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL -I. -I../../../../dist/include  -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nspr -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nss       -MD            -EHsc  -EHsc  -EHsc -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -FS -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O2 -GR- -GS- -favor:AMD64 -arch:AVX -Oy  c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Surface.cpp' failed, return code 1
evaluation from c:\Users\Vlada\comm-central\mozilla\config\recurse.mk:186:53:14:0: command 'c:/mozilla-build/python/python.exe c:/Users/Vlada/comm-central/mozilla/build/pymake/pymake/../make.py -C src/libEGL libs' failed, return code 2
evaluation from c:\Users\Vlada\comm-central\mozilla\config\recurse.mk:186:53:14:0: command 'c:/mozilla-build/python/python.exe c:/Users/Vlada/comm-central/mozilla/build/pymake/pymake/../make.py -C angle libs' failed, return code 2
c:\Users\Vlada\comm-central\mozilla\config\recurse.mk:159:0: command 'c:/mozilla-build/python/python.exe c:/Users/Vlada/comm-central/mozilla/build/pymake/pymake/../make.py -C gfx libs' failed, return code 2
c:\Users\Vlada\comm-central\mozilla\config\rules.mk:635:0: command 'c:/mozilla-build/python/python.exe c:/Users/Vlada/comm-central/mozilla/build/pymake/pymake/../make.py libs' failed, return code 2
c:\Users\Vlada\comm-central\objdir-sm-release\Makefile:52:0: command 'c:/mozilla-build/python/python.exe c:/Users/Vlada/comm-central/mozilla/build/pymake/pymake/../make.py -C mozilla default' failed, return code 2
Traceback (most recent call last):
  File "./build/pymake/make.py", line 35, in <module>
    main(sys.argv[1:])
  File "./build/pymake/make.py", line 32, in main
    subprocess.check_call([sys.executable, PYMAKE] + args)
  File "c:\mozilla-build\python\lib\subprocess.py", line 542, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['c:\\mozilla-build\\python\\python.exe', 'c:\\Users\\Vlada\\comm-central\\mozilla\\build\\pymake\\make.py', '-C', 'objdir-sm-release']' returned non-zero exit status 2

Vlada@PC1 ~/comm-central
$

Comment 7

4 years ago
1) Where define 'std' - directly in "Surface.cpp" and how to please ???

2) I now canot use "ac_add_options --with-windows-version=602" (or better 603) ???
   (i canot compile in Windows 8.1 with VS2013 and SDK 8.1) ... :-(

HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH
c:\Users\Vlada\comm-central\mozilla\config\rules.mk:1076:0$ mozbuild.action.cl main  cl -FoSurface.obj -c   -DLIBEGL_EXPORTS -DANGLE_BUILD -DNOMINMAX -D_CRT_SECURE_NO_DEPRECATE -D_SECURE_SCL=0 -DANGLE_DISABLE_TRACE -DANGLE_COMPILE_OPTIMIZATION_LEVEL=D3DCOMPILE_OPTIMIZATION_LEVEL1 -DNO_NSPR_10_SUPPORT -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../../include/KHR -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/.. -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/../libGLESv2 -I"C:/Program Files (x86)/Microsoft DirectX SDK (June 2010)/include" -Ic:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL -I. -I../../../../dist/include  -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nspr -Ic:/Users/Vlada/comm-central/objdir-sm-release/mozilla/dist/include/nss       -MD            -EHsc  -EHsc  -EHsc -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -FS -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O2 -GR- -GS- -favor:AMD64 -arch:AVX -Oy  c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Surface.cpp
Surface.cpp
c:\Users\Vlada\comm-central\mozilla\gfx\angle\src\libGLESv2/renderer/Renderer.h(27) : warning C4996: 'GetVersion': was declared deprecated
        C:\Program Files (x86)\Windows Kits\8.1\include\um\sysinfoapi.h(110) : see declaration of 'GetVersion'
c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Surface.cpp(378) : error C2039: 'max' : is not a member of 'std'
c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Surface.cpp(378) : error C3861: 'max': identifier not found
c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Surface.cpp(379) : error C2039: 'min' : is not a member of 'std'
c:/Users/Vlada/comm-central/mozilla/gfx/angle/src/libEGL/Surface.cpp(379) : error C3861: 'min': identifier not found

HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH
c:\program files (x86)\microsoft directx sdk (june 2010)\include\d3d10.h(608) : warning C4005: 'D3D10_ERROR_TOO_MANY_UNIQUE_STATE_OBJECTS' : macro redefinition
        C:\Program Files (x86)\Windows Kits\8.1\include\shared\winerror.h(50355) : see previous definition of 'D3D10_ERROR_TOO_MANY_UNIQUE_STATE_OBJECTS'
c:\program files (x86)\microsoft directx sdk (june 2010)\include\d3d10.h(609) : warning C4005: 'D3D10_ERROR_FILE_NOT_FOUND' : macro redefinition
        C:\Program Files (x86)\Windows Kits\8.1\include\shared\winerror.h(50364) : see previous definition of 'D3D10_ERROR_FILE_NOT_FOUND'
HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH
(Assignee)

Comment 8

4 years ago
Just apply the attached patch.

Comment 9

4 years ago
Thang You, but "Attachment #774468 [details] [diff]" says "Adress not found" :-(

Comment 10

4 years ago
Thang You - i not see "https://codereview.appspot.com/12665047/" and problem with "error C2039" now solved, but "ac_add_options --with-windows-version=603" for compilation canot use please ?

Comment 11

4 years ago
Now i have (similar) error:

comm-central\mozilla\toolkit\components\protobuf\google/protobuf/wire_format_lite_inl.h(270) : error C3861: 'min': identifier not found

Comment 12

4 years ago
I mus too in some other files add "#include <algorithm>"
Created attachment 831985 [details] [diff] [review]
unbitrot:  Add missing include <algorithm> to make it build

Unbitrotting previous patch. Worked for me.
Attachment #774468 - Attachment is obsolete: true
(Assignee)

Comment 14

4 years ago
Created attachment 8358763 [details] [diff] [review]
Fix Angle to build on Visual Studio 2013

I would not like to apply the local patch forever. Taking.
Assignee: nobody → VYV03354
Attachment #831985 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8358763 - Flags: review?(bjacob)
Comment on attachment 8358763 [details] [diff] [review]
Fix Angle to build on Visual Studio 2013

Review of attachment 8358763 [details] [diff] [review]:
-----------------------------------------------------------------

R+, but please upstream it by filing a bug at http://code.google.com/p/angleproject/issues/list
Attachment #8358763 - Flags: review?(bjacob) → review+
The patch WFM in my local build.
(Assignee)

Comment 17

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e05fe15821e

(In reply to Benoit Jacob [:bjacob] from comment #15)
> R+, but please upstream it by filing a bug at
> http://code.google.com/p/angleproject/issues/list

Done.
http://code.google.com/p/angleproject/issues/detail?id=547&thanks=547&ts=1389466481
https://hg.mozilla.org/mozilla-central/rev/0e05fe15821e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Component: Graphics → Canvas: WebGL
Strange, the only change I needed to make was adding the <algorithm> include after <tchar.h> in libEGL/Surface.cpp.
(Assignee)

Comment 20

4 years ago
(In reply to Jeff Gilbert [:jgilbert] from comment #19)
> Strange, the only change I needed to make was adding the <algorithm> include
> after <tchar.h> in libEGL/Surface.cpp.

Did you build the tree in non-unified mode?
In unified mode, it would be sufficient to include a file from at most one file.
(In reply to Masatoshi Kimura [:emk] from comment #20)
> (In reply to Jeff Gilbert [:jgilbert] from comment #19)
> > Strange, the only change I needed to make was adding the <algorithm> include
> > after <tchar.h> in libEGL/Surface.cpp.
> 
> Did you build the tree in non-unified mode?
> In unified mode, it would be sufficient to include a file from at most one
> file.

Ah, of course. Good catch. :)
You need to log in before you can comment on or make changes to this bug.