Closed Bug 892939 Opened 7 years ago Closed 7 years ago

[Bluetooth] Remove PrepareAdapterTask

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(1 file)

The purpose of PrepareAdapterTask is to set a global variable on the main thread and then schedule PrepareAdapterRunnable on the Bluetooth command thread. Once bug 891866 and bug 892933 landed, PrepareAdapterRunnable will not block any longer. This will allow us to merge the code of PrepareAdapterTask into PrepareAdapterRunnable, and run PrepareAdapterRunnable directly on the main thread.
Attachment #784862 - Flags: review?(gyeh)
Attachment #784862 - Flags: review?(echou)
Comment on attachment 784862 [details] [diff] [review]
Bug 892939: Remove PrepareAdapterTask

Review of attachment 784862 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed.

::: dom/bluetooth/linux/BluetoothDBusService.cpp
@@ +1256,5 @@
>  class PrepareAdapterRunnable : public nsRunnable
>  {
>  public:
> +  PrepareAdapterRunnable(const nsAString& aAdapterPath)
> +  : mAdapterPath(aAdapterPath)

super-nit: 2-space indentation, please.
Attachment #784862 - Flags: review?(echou) → review+
Comment on attachment 784862 [details] [diff] [review]
Bug 892939: Remove PrepareAdapterTask

Review of attachment 784862 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. Thanks!
Attachment #784862 - Flags: review?(gyeh) → review+
https://hg.mozilla.org/mozilla-central/rev/2123670ffb9d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.