892939 - [Bluetooth] Remove PrepareAdapterTask

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

The purpose of PrepareAdapterTask is to set a global variable on the main thread and then schedule PrepareAdapterRunnable on the Bluetooth command thread. Once bug 891866 and bug 892933 landed, PrepareAdapterRunnable will not block any longer. This will allow us to merge the code of PrepareAdapterTask into PrepareAdapterRunnable, and run PrepareAdapterRunnable directly on the main thread.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Bug 892939: Remove PrepareAdapterTask

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 784862 [details] [diff] [review]
Bug 892939: Remove PrepareAdapterTask

Review of attachment 784862 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed.

::: dom/bluetooth/linux/BluetoothDBusService.cpp
@@ +1256,5 @@
>  class PrepareAdapterRunnable : public nsRunnable
>  {
>  public:
> +  PrepareAdapterRunnable(const nsAString& aAdapterPath)
> +  : mAdapterPath(aAdapterPath)

super-nit: 2-space indentation, please.

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 784862 [details] [diff] [review]
Bug 892939: Remove PrepareAdapterTask

Review of attachment 784862 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. Thanks!

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

The super nit has been fixed. Thanks! :)

https://hg.mozilla.org/integration/b2g-inbound/rev/2123670ffb9d

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2123670ffb9d