893238 - Signature graphs are missing

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot showing missing Graph for signature

The graph isn't displaying for signature reports.

STR:

1. Load Top Changers (https://crash-stats.mozilla.com/topchangers/products/Firefox)
2. Click on a signature/top frame
3. Now click on "Graph"

Actual Results:

No graph appears at all; no JS errors, either, that I can see.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

<div id="buildid-graph"></div> - so it's totally missing, which explains why there aren't any JS errors, I guess.

Comment 2

[Selena Deckelmann :selenamarie :selena]

Having a look, but struggling to figure out how the data is getting from the middleware to that graph object.

Comment 3

[Selena Deckelmann :selenamarie :selena]

PR https://github.com/mozilla/socorro/pull/1345 fixes this issue!

Comment 4

[Peter Bengtsson [:peterbe]]

After talking to Selena, we decided I'll give it a try.

Comment 5

[Peter Bengtsson [:peterbe]]

New PR: https://github.com/mozilla/socorro/pull/1354 r?

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7d673b954fbc5405046e812271c09fc2ff53dba0
fixes bug 893238 - signature graphs loading, r=AdrianGaudebert

Comment 7

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened

Reopening:

* The graphs are appearing yet I haven't been able to find one that is populated with data in it. Example, https://crash-stats.allizom.org/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-07-29&signature=js%3A%3Aion%3A%3ABailoutIonToBaseline%28JSContext%2A%2C+js%3A%3Aion%3A%3AIonActivation%2A%2C+js%3A%3Aion%3A%3AIonBailoutIterator%26%2C+bool%2C+js%3A%3Aion%3A%3ABaselineBailoutInfo%2A%2A%29&version=Firefox%3A23.0b8#graph.

* The graph area isn't responsive to resizing of the browser window. Note on all but the largest monitors this could be a problem.

Comment 8

[Peter Bengtsson [:peterbe]]

Attachment: Screen Shot 2013-07-29 at 11.31.38 AM.png

Topmost crash on stage.

Comment 9

[Peter Bengtsson [:peterbe]]

Attachment: Screen Shot 2013-07-29 at 11.32.22 AM.png

Loads a graph just fine :)

Comment 10

[Matt Brandt [:mbrandt]]

Thanks peterbe .. can you shed light on the 2nd question?

Comment 11

[Peter Bengtsson [:peterbe]]

I don't know why but the graph appears to have some sort of hardcode width thing set to 1200. 
https://github.com/mozilla/socorro/blob/master/webapp-django/crashstats/crashstats/static/crashstats/js/socorro/report_list_graph.js#L39

Either way, it's not my fault :)
And it's not part of the graph not appearing. It would require a followup bug.

Comment 12

[Matt Brandt [:mbrandt]]

bumping to resolved per comment 9

Comment 13

[Matt Brandt [:mbrandt]]

QA verified on stage - thank you peterbe for digging deeper. I'll file a separate bug for the re-sizing issues. I hadn't realized this was something that we hardcoded.

Comment 15

[Shuhao]

Are we sure this is fixed? 

I cannot confirm this from this page: https://crash-stats.mozilla.com/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-08-20&signature=js%3A%3AWorkerThreadState%3A%3AfinishParseTaskForScript%28JSScript*%29&version=Firefox%3A26.0a1#graph

Comment 16

[Selena Deckelmann :selenamarie :selena]

(In reply to Shuhao Wu [:Pwnna] from comment #15)
> Are we sure this is fixed? 
> 
> I cannot confirm this from this page:
> https://crash-stats.mozilla.com/report/
> list?product=Firefox&range_value=7&range_unit=days&date=2013-08-
> 20&signature=js%3A%3AWorkerThreadState%3A%3AfinishParseTaskForScript%28JSScri
> pt*%29&version=Firefox%3A26.0a1#graph

Yes -- problem is backfill and configuration, fixing in https://bugzilla.mozilla.org/show_bug.cgi?id=907341

Comment 17

[Matt Brandt [:mbrandt]]

Reopening - this appears to have regressed. Signature graphs are missing from all crash signatures.

Comment 18

[Peter Bengtsson [:peterbe]]

Attachment: Screen Shot 2013-09-16 at 10.09.57 AM.png

I think that when https://bugzilla.mozilla.org/show_bug.cgi?id=758054#c5 landed it also fixed this.

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats.mozilla.com/report/list?product=Firefox&range_value=14&range_unit=days&signature=js%3A%3AGCMarker%3A%3AprocessMarkStackTop%28js%3A%3ASliceBudget%26%29&version=Firefox:33.0a1&version=Firefox:32.0a2&version=Firefox:31.0b&version=Firefox:30.0#tab-graph and others -- sorry for the epic delay :-\

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot