893283 - Developer's name is missing from app

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot, comparing dev and prod

STR:

1. Load https://marketplace-dev.allizom.org/app/twitter?src=featured
2. Look for the developer's name

Actual Results:

It's missing

(Compare screenshots.)

Sauce Labs video: https://saucelabs.com/jobs/33eec10e2e7f494ba5a6519982cb5faf

Comment 1

[Rob Hudson [:robhudson]]

Caused from Chuck's recent commit. Version is now its own resource. "current_version" went from being in the js object to a string that then needs to be pulled from versions (which is of the form {"1.0": "/path/to/resource"} to get the developer name and release notes.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

https://github.com/mozilla/zamboni/commit/63c490b3dd309c0f2ad296cde4caa41fc6fd1541

Comment 4

[Matt Basta [:basta]]

https://github.com/mozilla/fireplace/commit/f3ac13e4ca6bd80c3bb8fe8978631b5dc53fa43d

Comment 5

[Matt Basta [:basta]]

yoink

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://marketplace-dev.allizom.org/app/twitter?src=featured.

Comment 8

[Christopher Van Wiemeersch [:cvan]]

The developer name that was rendered was incorrect.

"Twitter, Inc." was the name of the user account who owned the Twitter app.

Per bug 785125, we now pull the developer name from the app manifest. From Twitter's manifest https://mobile.twitter.com/cache/twitter.webapp:

    ...
    "developer": {
        "name": "Twitter", 
        "url": "http://twitter.com"
    }, 
    ...

So we should be showing "Twitter" not "Twitter, Inc." as the developer name.

Fixed:
https://github.com/mozilla/zamboni/commit/21b105b
https://github.com/mozilla/zamboni/commit/ef2975e
https://github.com/mozilla/fireplace/commit/a1c66ee

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Nice catch, thx again, cvan.

<3

Comment 10

[Vaidik Kapoor [:vaidik]]

We are seeing this prod now. Our automated test caught this.

Screenshot: http://imgur.com/kFEjamd

Comment 11

[Christopher Van Wiemeersch [:cvan]]

We're in the middle of a push and we're reindexing our search/detail pages (so you may see blank spots for a while); wait until it's done. Please reopen if needed. Thanks!

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://marketplace.firefox.com/app/twitter?src=featured.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot, redeux