Developer's name is missing from app

VERIFIED FIXED in 2013-07-18

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: stephend, Assigned: basta)

Tracking

({regression})

2013-07-18
regression
Points:
---

Details

(Whiteboard: [fromAutomation], URL)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 775022 [details]
Screenshot, comparing dev and prod

STR:

1. Load https://marketplace-dev.allizom.org/app/twitter?src=featured
2. Look for the developer's name

Actual Results:

It's missing

(Compare screenshots.)

Sauce Labs video: https://saucelabs.com/jobs/33eec10e2e7f494ba5a6519982cb5faf
(Reporter)

Updated

5 years ago
Keywords: regression
Caused from Chuck's recent commit. Version is now its own resource. "current_version" went from being in the js object to a string that then needs to be pulled from versions (which is of the form {"1.0": "/path/to/resource"} to get the developer name and release notes.

Updated

5 years ago
Duplicate of this bug: 882097
Assignee: nobody → charmston
Target Milestone: --- → 2013-07-18
Assignee: charmston → cvan
(Assignee)

Comment 4

5 years ago
https://github.com/mozilla/fireplace/commit/f3ac13e4ca6bd80c3bb8fe8978631b5dc53fa43d
Assignee: cvan → mattbasta
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
yoink
(Reporter)

Comment 6

5 years ago
Created attachment 776761 [details]
Post-fix screenshot
(Reporter)

Comment 7

5 years ago
Verified FIXED on https://marketplace-dev.allizom.org/app/twitter?src=featured.
Status: RESOLVED → VERIFIED
The developer name that was rendered was incorrect.

"Twitter, Inc." was the name of the user account who owned the Twitter app.

Per bug 785125, we now pull the developer name from the app manifest. From Twitter's manifest https://mobile.twitter.com/cache/twitter.webapp:

    ...
    "developer": {
        "name": "Twitter", 
        "url": "http://twitter.com"
    }, 
    ...

So we should be showing "Twitter" not "Twitter, Inc." as the developer name.

Fixed:
https://github.com/mozilla/zamboni/commit/21b105b
https://github.com/mozilla/zamboni/commit/ef2975e
https://github.com/mozilla/fireplace/commit/a1c66ee
(Reporter)

Comment 9

5 years ago
Nice catch, thx again, cvan.

<3
We are seeing this prod now. Our automated test caught this.

Screenshot: http://imgur.com/kFEjamd
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
We're in the middle of a push and we're reindexing our search/detail pages (so you may see blank spots for a while); wait until it's done. Please reopen if needed. Thanks!
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 12

5 years ago
Verified FIXED on https://marketplace.firefox.com/app/twitter?src=featured.
Status: RESOLVED → VERIFIED
(Reporter)

Comment 13

5 years ago
Created attachment 778661 [details]
Post-fix screenshot, redeux
You need to log in before you can comment on or make changes to this bug.