893358 - Add Italian keyboard layout support

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[[e-mail]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:25.0) Gecko/20130711 Firefox/25.0 (Nightly/Aurora)
Build ID: 20130711104256




Expected results:

It would be nice to have the Italian keyboard layout.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Walter Chen[:ypwalter][:wachen]]

Hi, Luigi,

I think reading this tutorial would be helpful for you =)
https://wiki.mozilla.org/L10n:B2G

As for your part, I think this you should reference
https://wiki.mozilla.org/L10n:B2G/Adding_Locales
and,  you can see instructions on "Technical Infrastructure" part

Hi, kscanne,

I believe you are more familiar in process of this.
Can you help on this?

Comment 3

[[e-mail]]

Hi Walter,
what am I missing? Should I add it to Elmo?

Comment 4

[Kevin Scannell]

Walter - I can help with word frequency data, but it appears that there is already a file for Italian in the repo:

https://github.com/mozilla-b2g/gaia/blob/master/dictionaries/it_wordlist.xml

Comment 5

[David Flanagan [:djf]]

Comment on attachment 775137 [details]
Proposed patch

Luigi,

Thanks for this patch!  It looks good, except for a couple of things I've noted on github. Mainly: you need to generate the it.dict file and check it in as part of the pull request.

Asking for feedback from Axel on this: Axel is this a localization issue at all? Luigi is a native speaker of Italian, so I expect he knows what a good italian keyboard layout is.  Does this need further review or can we land it on master?

Comment 6

[[e-mail]]

Hi David, I generated the it.dict file and put it in the correct path; I also tried this patch and the autosuggestion feature worked.

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Walter Chen from comment #2)
> As for your part, I think this you should reference
> https://wiki.mozilla.org/L10n:B2G/Adding_Locales
> and,  you can see instructions on "Technical Infrastructure" part

The Italian localization is already available on hg (and constantly updated), so not sure I understand this part
https://hg.mozilla.org/gaia-l10n/it

The only part missing from that section is the keyboard layout, and I guess this is what this bug is about
https://github.com/mozilla-b2g/gaia/blob/master/shared/resources/keyboard_layouts.json#L28

I don't know enough about keyboard layouts, but some things look quite wrong in apps/keyboard/js/layout.js 

Where does it.dict come from? I read it's generated, but I don't understand from what.

Comment 8

[[e-mail]]

Hi Francesco,
what's wrong with the keyboard layout? I think there is all you need for writing in Italian; anyway I'm opened to further changes. The it.dict file was generated from the wordlist inside gaia/dictionaries/it_wordlist.xml.

Cheers
Luigi

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Luigi Tedone from comment #8)
> Hi Francesco,
> what's wrong with the keyboard layout? 

Some character are not useful for Italian (IMO), others (ordinal forms) are just wrong, unless I'm misunderstanding the syntax of that file.

I commented on Github the lines that I think need improvement.

Comment 10

[[e-mail]]

Francesco, I fixed some typos. Tell me if it's OK also for you now.

Comment 11

[Francesco Lodolo [:flod]]

Just a couple of doubts about ordinals: does it make sense to have º on o (like you did) and ª on a?

Also, I would leave 

'1': '1° 1ª',
etc.

or
'1': '1° 1ª 1a',
etc.

'1a' is pretty easy to write on a keyboard, 1ª not really. Apart from that it looks good now for me.

Comment 12

[[e-mail]]

About °, I put it there because other keyboard layouts have the same behaviour. Anyway, I fixed also ordinal numbers; I hope now it would be ok.

Comment 13

[Francesco Lodolo [:flod]]

I think you still need to address David's comment about apps/settings/index.html

Comment 14

[[e-mail]]

Done. I'm sorry for so many commits. If it's a problem, I can try to squash them.

Comment 15

[[e-mail]]

flag?djf

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 775137 [details]
Proposed patch

flod's got this covered

Comment 17

[[e-mail]]

Any news?

Comment 18

[Joe Cheng [:jcheng] (please needinfo)]

we may need to add Italian to v1.1
so we will need the keyboard layouts / dictionaries like we did for bug 907763: Add Croatian, Dutch, Hungarian, and Romanian keyboard layouts for v1.1
can we start estimating the effort? thanks

Comment 19

[[e-mail]]

I also did a separate pull request on GitHub for adding updated dictionaries (such as Italian) but it was marked as duplicate and discarded.

Comment 20

[Joe Cheng [:jcheng] (please needinfo)]

leo+ as we will enable partner to work with us on supporting Italian release

Comment 21

[David Flanagan [:djf]]

(In reply to Joe Cheng [:jcheng] from comment #18)
> we may need to add Italian to v1.1
> so we will need the keyboard layouts / dictionaries like we did for bug
> 907763: Add Croatian, Dutch, Hungarian, and Romanian keyboard layouts for
> v1.1
> can we start estimating the effort? thanks

The effort will be minimal. Luigi is working now to squash his commits.  I'll review his patch and get this landed ASAP.

Comment 22

[David Flanagan [:djf]]

Taking this from Luigi since he is having git difficulties and won't be able to work on it until after the Summit.  

All I'm going to do is deal with merge conflicts and patch uplift.

Comment 23

[David Flanagan [:djf]]

Attachment: link to github pull request for v1-train

This is Luigi's patch rebased against v1-train with merge conflicts resolved.

Comment 24

[David Flanagan [:djf]]

Attachment: link to github pull request for master

This is Luigi's patch, slightly modified to work on master (and on v1.2, I think)

I'm not going to land this one right now because we already have too many autocorrect dictionaries causing problems.  Let's wait until bug 884752 lands first.  (Then this pull request will have to be updated)

Comment 25

[David Flanagan [:djf]]

Landed to v1-train: https://github.com/mozilla-b2g/gaia/commit/02b975e6ce12922928c74276ac7d19432a03f126

Leaving this bug open so we can get Italian into master and v1.2. But I want to wait to do that until bug 884752 lands.

Comment 26

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 12577c2bb635e5745602ec180e2c7ab05292ccda

Comment 27

[Francesco Lodolo [:flod]]

Attachment: Italian keyboard on v1-train

Just flashed v1-train on my device, I can confirm the presence of "Italiano" in settings->keyboard, layout and word suggestion works as expected.

Comment 28

[chris hofmann]

lloks like this is fixed everywhere.  is that correct?

Comment 29

[Francesco Lodolo [:flod]]

Still missing from master and v1.2

Comment 30

[sync-1]

Dear David,

I'm not find it.dict in dictionaries, is it missing?

Comment 31

[sync-1]

Sorry, I get it in v1-train. please ignore it.

Comment 32

[Delphine Lebédel [:delphine - Use needinfo]]

This is still missing from v1.2 and is becoming quite urgent as we still haven't been able to test it, and Italian is a v1.2 shipping locale
Requesting koi? on this one

Comment 33

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Looks like this fall through the crack but I expect it to be trivial. djf, would you work on this or do you need some help here?

Comment 34

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/13248

This bug is > 1 month overdue because of bug 884752.

I believe after that bug an it.dict and a layouts/it.js is all we need to add a new language right?

Comment 35

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 825167 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/13248

I think layout and dictionary is all we need here.

I don't see we updated it.dict in Bug 884752, so leave the review flag open for David to confirm that it.dict we used is already up-to-date.

Comment 36

[[e-mail]]

When I wrote the first patch for the Italian keyboard the it.dict wasn't present. I used the it_wordlist.xml file that is currently into the folder gaia/keyboard/dictionaries for generating it, so the version of the Italian dictionary in David's patch is 15.

Comment 37

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Luigi Tedone from comment #36)
> When I wrote the first patch for the Italian keyboard the it.dict wasn't
> present. I used the it_wordlist.xml file that is currently into the folder
> gaia/keyboard/dictionaries for generating it, so the version of the Italian
> dictionary in David's patch is 15.

Yes, the it.dict I used is the the one in v1.1.0hd from your commit.

Comment 38

[David Flanagan [:djf]]

Thanks Tim, for bringing this back up.

Delphine: with this bug landed, you should be able to test the Italian layout in 1.2. Note, however, that in order to produce a build with the italian keyboard in it you will need to customize the GAIA_KEYBOARD_LAYOUTS enviroment variable.  Use something like this:

  GAIA_KEYBOARD_LAYOUTS=en,es,it make reset-gaia

Comment 39

[David Flanagan [:djf]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/4d468a5d00a02914fb440d50110a4e5e052adc8e

Comment 40

[David Flanagan [:djf]]

Uplifted to v1.2: https://github.com/mozilla-b2g/gaia/commit/9d22b39245c8d7e77f384866c392701101ee86b0

Comment 41

[Delphine Lebédel [:delphine - Use needinfo]]

Ok thanks David!

Comment 42

[Delphine Lebédel [:delphine - Use needinfo]]

Great, looks good to me!
Flod, would you mind double checking that everything is OK as well? thanks

Comment 43

[Francesco Lodolo [:flod]]

Yes, working great: I found Italian in the available keyboards, word suggestions and layout are correct.

I've also updated our reference document
https://l10n.etherpad.mozilla.org/gaia-multilocale