907763 - Add Croatian, Dutch, Hungarian, and Romanian keyboard layouts for v1.1

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Delphine Lebédel [:delphine - Use needinfo]]

Here are the v1.1 locales that l10n team has available for v1.1:
https://l10n.mozilla.org/shipping/dashboard?tree=gaia

Some characters seem to be missing from keyboard in some locales, which is descreibed in bug 905051

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Leo+ as some partners require these to ship

Polish, Croatian, Czech, English, German, Romanian, Hungarian, Greek, Bulgarian, Dutch, Russian, Slovak, Turkish, Croatian          

Hungarian, Serbian

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

from the email thread. Missing keyboard layouts: Croatian, Dutch, Hungarian, Romanian, Bulgarian

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Added localizers
Please note we do not have Bulgarian on our radar for v1.1

Comment 4

[Raul Nicolae Malea]

For Romanian need: ă,î,â,ț,ș, „, ”  and others.

Comment 5

[Vlado Valastiak [:wladow]]

(In reply to Joe Cheng [:jcheng] from comment #2)
> from the email thread. Missing keyboard layouts: Croatian, Dutch, Hungarian,
> Romanian, Bulgarian
Slovak's missing too

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Vlado Valastiak [:wladow] @ Mozilla.sk from comment #5)
> (In reply to Joe Cheng [:jcheng] from comment #2)
> > from the email thread. Missing keyboard layouts: Croatian, Dutch, Hungarian,
> > Romanian, Bulgarian
> Slovak's missing too

I think we do have Slovak, which is included in the "Other latins" group.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11717

Pointer to Github pull-request

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 794587 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11717

Hi David,

We add Croatian, Dutch, Hungarian, and Bulgarian keyboard layouts and also uplift Romanian layout from master.

Besides, we remove the "other latins" grouping since we would use non-localized strings for each keyboard layout name.

Please help review this patch.
Thanks.

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

correction on comment 2:
from the email thread. Missing keyboard layouts: Croatian, Dutch, Hungarian, Romanian

Bulgarian is actually not needed. sorry about the incorrect information

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Joe Cheng [:jcheng] from comment #9)
> correction on comment 2:
> from the email thread. Missing keyboard layouts: Croatian, Dutch, Hungarian,
> Romanian
> 
> Bulgarian is actually not needed. sorry about the incorrect information

It's ok.
My pull request has been updated to remove Bulgarian.

Comment 13

[Delphine Lebédel [:delphine - Use needinfo]]

Please note that Russian has keyboard issues too: see Bug 908350 and 908343 (already have been attached to this bug)

Comment 14

[David Flanagan [:djf]]

Comment on attachment 794587 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11717

One minor nit noted on github, but otherwise this looks good to me.

I can't review the correctness of the layouts, but have verified that the layouts now exist.

This is landing just to v1-train for now. I'll leave the bug open for a followup pull request for master.

Comment 15

[David Flanagan [:djf]]

Landed to v1-train: https://github.com/mozilla-b2g/gaia/commit/c39e93105bbeb593e392705ed16ef040769698e8

Leaving the bug open so that we can also land to master.

Comment 16

[David Flanagan [:djf]]

(In reply to Raul Malea from comment #4)
> For Romanian need: ă,î,â,ț,ș, „, ”  and others.

If you could file a new bug for that, and mark it as blocking this one it would be very helpful, especially if you could list all of the "and others".

Comment 17

[David Flanagan [:djf]]

I notice that on master, we have two layouts for turkish: tr-f and tr-q but only have one layout (I think the tr-q version) in 1.1.  If we want to support both of these in v1.1, we'll need to uplift that.

Setting needinfo on Joe and Delphine in case one of them knows the answer to this.  If yes, I think we should file a separate child bug for it.

Comment 18

[Delphine Lebédel [:delphine - Use needinfo]]

I don't know. Adding Turkish localizer as he might know a bit more about this as well

Comment 19

[Selim Şumlu]

Please see bug 868417 for more info on Turkish-F layout.

I was the one to request it, but I'm not sure if it was supposed to be included in 1.1 or not. It would be very nice to include it, of course.

Comment 20

[David Flanagan [:djf]]

Rudy: when you land these new layouts in master, please be sure to set the autoCorrectLanguage property for them to match what I have done in Bug 908286

Comment 21

[Raul Nicolae Malea]

(In reply to David Flanagan [:djf] from comment #16)
> (In reply to Raul Malea from comment #4)
> > For Romanian need: ă,î,â,ț,ș, „, ”  and others.
> 
> If you could file a new bug for that, and mark it as blocking this one it
> would be very helpful, especially if you could list all of the "and others".

Romanian keyboard must contain the characters enumerated by me. Now, they do not appear (b2g 1.1.0, build 20130821045512). So, I cannot verify that it has not yet been implemented. I just did a comment of the facts. 

More details on Romanian keyboard here: 

- http://romanian.typeit.org/
- http://en.wikipedia.org/wiki/Romanian_keyboard_layout
- http://www.secarica.ro/html/ro_keyboard.html 


When this bug will be resolved we will do a review and if other problems we open another bug (similar to bug 886628)

Comment 22

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Change flag according to comment 15.

Comment 23

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: c39e93105bbeb593e392705ed16ef040769698e8
v1.1.0hd: ed8dac2ac3b424a169e37d603cec8ff8ad6e09f2

Comment 24

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to David Flanagan [:djf] from comment #17)
> I notice that on master, we have two layouts for turkish: tr-f and tr-q but
> only have one layout (I think the tr-q version) in 1.1.  If we want to
> support both of these in v1.1, we'll need to uplift that.
> 
> Setting needinfo on Joe and Delphine in case one of them knows the answer to
> this.  If yes, I think we should file a separate child bug for it.

Wilfred, do you know which Turkish is our partner requesting for v1.1? or we are good for now with one of it

Comment 25

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to David Flanagan [:djf] from comment #20)
> Rudy: when you land these new layouts in master, please be sure to set the
> autoCorrectLanguage property for them to match what I have done in Bug 908286

A good chunk of this patch is already on master through previous work (which could have been uplifted in the end to v1-train):
- remove 'otherLatins', splitting each kb layout in its own setting -- bug 867883
- add Romanian keyboard layout -- bug 886628
- add Hungarian keyboard layout -- bug 905051

Landing this patch on master would create a huge conflict mess and might end up in some subtle regressions... I would suggest simply creating a new patch that adds the new keyboard layouts (Dutch, Croatian) to master since everything else is already there.

Moreover, I see that this patch completely removes l10n for the keyboard layout labels in the Settings App, however not all labels are switched to their native language equivalent: for Greek it is simply 'Greek' instead of Ελληνικός (maybe a Greek native speaker can provide a better label here).

Comment 26

[Wilfred Mathanaraj [:WDM]]

TR-Q (standard QWERTY layout with the 6 extra Turkish characters) is the most commonly used one on all mobile devices. 
TR-F is nice to have but not a must for the countries we are considering for launch at the moment.

Comment 27

[Preeti Raghunath(:Preeti)]

Delphine,

Please check if this the only list of languages.

Comment 28

[Selim Şumlu]

Do we have a policy for unused characters, and the order for special characters? 
For example, when I press and hold "i" on the Turkish keyboard, I see 7 different accented characters but only one of those (ı) is actually in the Turkish alphabet.

Comment 29

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Selim Sumlu from comment #28)
> Do we have a policy for unused characters, and the order for special
> characters? 
> For example, when I press and hold "i" on the Turkish keyboard, I see 7
> different accented characters but only one of those (ı) is actually in the
> Turkish alphabet.

Hi Selim,

Thanks for your feedback.
I know nothing about Turkish, but I tried Turkish keyboard layout on Android and iOS, I can see those accented chars in their layouts.

Can you please help us understand what might be the reason?
If you still have any concerns, please feel free to file a bug and we can discuss how to address this on that bug.

Thanks.

Comment 30

[Selim Şumlu]

(In reply to Rudy Lu [:rudyl] from comment #29)
> (In reply to Selim Sumlu from comment #28)
> > Do we have a policy for unused characters, and the order for special
> > characters? 
> > For example, when I press and hold "i" on the Turkish keyboard, I see 7
> > different accented characters but only one of those (ı) is actually in the
> > Turkish alphabet.
> 
> Hi Selim,
> 
> Thanks for your feedback.
> I know nothing about Turkish, but I tried Turkish keyboard layout on Android
> and iOS, I can see those accented chars in their layouts.
> 
> Can you please help us understand what might be the reason?
> If you still have any concerns, please feel free to file a bug and we can
> discuss how to address this on that bug.
> 
> Thanks.

You're right, but the experience is different:

On iOS, Turkish characters are already available on the default layout and only unused (outside of the Turkish alphabet) characters are available in popups.
On Android, Turkish characters are available in popups, but the default selection is always the Turkish character in popup.

Comment 31

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Selim Sumlu from comment #30)

> 
> You're right, but the experience is different:
> 
> On iOS, Turkish characters are already available on the default layout and
> only unused (outside of the Turkish alphabet) characters are available in
> popups.

I guess you're talking about iOS 6, is it Turkish F or Turkish Q?
I don't have an iOS 6 around, so will find one to confirm this.

> On Android, Turkish characters are available in popups, but the default
> selection is always the Turkish character in popup.

To mimic the same behavior, I think we only need to change the order of the accented character shown in the pop up.
The code lives in Gaia's apps/keyboard/js/layout.js, want to give it a try to submit a patch? :)

Thanks again for the great feedback.

Comment 32

[Delphine Lebédel [:delphine - Use needinfo]]

Sorry for not answering before, was on PTO until today.
The list of total languages that we needed keyboard layouts for v1.1 can be found here: https://l10n.mozilla.org/shipping/dashboard?tree=gaia

This list contains Catalan, Czech, German, Greek, Spanish, Croatian, Hungarian, Dutch, Polish, Brazilian Portuguese, Romanian, Russian, Slovak, Serbian Cyrillic, Serbian Latin and Turkish

For keyboard layouts, we had identified Croatian, Dutch, Hungarian, Romanian and Russian as having missing keyboard characters/layouts. From what I understand, Russian has finally not made it into v1.1. Also, the auto-correct dictionary was missing for Slovak (Bug 908938).
Please let me know if you need any more information.

Comment 33

[sarsenyev]

The issue is fixed on Leo COM RIL 1.1, all keyboards layout are added for 1.1 locales, all missing characters are implemented

Environmental  Variables:
Build ID: 20130904041204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/307824edadd7
Gaia: d0a415bbf23e5d01c2b287d9fca708e167cfe70d
Platform Version: 18.1
RIL Version: 01.01.00.019.212
Firmware revision: D300f10a

Comment 34

[Selim Şumlu]

(In reply to Rudy Lu [:rudyl] from comment #31)
> (In reply to Selim Sumlu from comment #30)
> 
> > 
> > You're right, but the experience is different:
> > 
> > On iOS, Turkish characters are already available on the default layout and
> > only unused (outside of the Turkish alphabet) characters are available in
> > popups.
> 
> I guess you're talking about iOS 6, is it Turkish F or Turkish Q?
> I don't have an iOS 6 around, so will find one to confirm this.
> 
> > On Android, Turkish characters are available in popups, but the default
> > selection is always the Turkish character in popup.
> 
> To mimic the same behavior, I think we only need to change the order of the
> accented character shown in the pop up.
> The code lives in Gaia's apps/keyboard/js/layout.js, want to give it a try
> to submit a patch? :)
> 
> Thanks again for the great feedback.

The patch is ready and I've already made a pull request (https://github.com/maxcoder/gaia/commit/07c95dfd1fdb767d10bddf1bebf77c20b17e2c8d) but I'm sure someone needs to review it first.

Do I need to file a seperate bug? Can you guide me for that?

Comment 35

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, please file a separate bug for your change since this bug has been closed and verified.
For filing a bug, you may start from,
https://bugzilla.mozilla.org/enter_bug.cgi?product=Boot2Gecko&component=Gaia%3A%3AKeyboard

Please help make sure the "summary" and "description" are clear enough for the issue we want to address.
Thanks.

(More details on filing a bug,
http://fantasai.inkedblade.net/style/talks/filing-good-bugs/)

Comment 36

[Karen Ward [:kward]]

Rudy - Should this bug be closed as complete now?

Comment 37

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, I think we should close this and handle the rest for Gaia master/v1.2 in another bug.