893560 - [System] Display a keyboard switching shortcut on utility tray when a keyboard is in use

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Evelyn Hung]

To ensure the user has a way to switch to another keyboard app or layout, we need this shortcut on utility tray when a keyboard app is in use.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Is there UX for this?

Comment 2

[Evelyn Hung]

I put UX draft on the user story meata bug 891678. Will update there for the UX spec.

Comment 3

[Ivan Tsay (:ITsay)]

Add keywords in whiteboard for tracking
Flag to koi+ for FFOS 1.2 must have

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

I almost finished this bug, except the keyboard icon described in the specification (Attachment 776309 [details])(the middle frame at page 8). Although it seems the same with Settings -> Personalization -> Keyboard 's, but I can't reference to it because the Settings is another app, which holds its resources exclusively.

I can copy it to the System app's resource directory. However, the icon is a part of the CSS sprite, and the other parts of the sprite will occupy unnecessary spaces. So it's not a good solution unless the System app actually need the sprite, too. 

Another way to solve this is to create a standalone keyboard icon, but this need be implemented by UX.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Modifications:

1. Add a fake notification in the utility tray.
2. Bind events on it.
3. Do preventDefault to prevent focus changing while user is in the tray and the list.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 798782 [details]
Patch

1. Fire events from keyboard manager to utility tray if possible.
2. Fire events from keyboard manager to list menu if possible.
3. Do removeEventListener when you don't need it anymore.
4. Some other coding style change.

So the whole story is keep every module as independent as possible, please don't touch other modules or elements directly.

BTW, doesn't click on list menu items fires blur to user app?

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

(In reply to Alive Kuo [:alive] from comment #6)
> Comment on attachment 798782 [details]
> Patch
> 
> 1. Fire events from keyboard manager to utility tray if possible.
> 2. Fire events from keyboard manager to list menu if possible.
> 3. Do removeEventListener when you don't need it anymore.
> 4. Some other coding style change.
> 
> So the whole story is keep every module as independent as possible, please
> don't touch other modules or elements directly.
> 
> BTW, doesn't click on list menu items fires blur to user app?

Thanks for reviewing. I've re-committed my patch on GitHub and followed your instructions.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 798782 [details]
Patch

Nearly done. Please fix what I addressed in github. Come to me if you have problems.

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 798782 [details]
Patch

I've finished it according to the lastest comments on GitHub. If it's qualified, please merge for me (permission issue). Thanks.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 798782 [details]
Patch

See github comment. Sorry for late feedback.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 798782 [details]
Patch

Thanks. I've fixed the code, and leave a question about the z-index on GitHub.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 798782 [details]
Patch

r+ if the last comments are addressed.
Though this bug takes a long time to go but we finally have a more 'decoupled' and modularized modification than your first patch.

Thanks for the patience!

Comment 13

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

merged in gaia master
https://github.com/mozilla-b2g/gaia/commit/fab7c6b8d9d23e9734ee67498abdd1435b127641
https://github.com/mozilla-b2g/gaia/commit/7691c10ae86e7cc71d3501752e84bd11f5851383

thanks Greg and Alive