894263 - [Buri][Settings]The "power save mode" function abnormally

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.152
 Firefox os  v1.1
 Mozilla build ID:20130702230206
 
 Created an attachment (id=462502)
 The log
 
 DEFECT DESCRIPTION:
 The "power save mode" function is abnormal after select"15% battery left",then 
 select"never".
 
 REPRODUCING PROCEDURES:
 1.Access Settings app.->Battery->See current level is 14%->Turn on automatically->15% battery left->OK->You'll see  "power save mode" is turned on ->OK
 2.Continue to click "Turn on automatically"->never->OK->You'll see  "power save 
 mode" is still turned on->KO
 3.If you click "Turn on automatically"->5% battery left->OK->You'll see "power save mode" is turned off->Continue to click "Turn on automatically"->never->OK->You'll see  "power save mode" is still turned off.->OK
 
 EXPECTED BEHAVIOUR:
 The "power save mode" function should work normally.->OK
 
 ASSOCIATE SPECIFICATION:
 TEST PLAN REFERENCE:
 TOOLS AND PLATFORMS USED:
 USER IMPACT:
 Mid
 REPRODUCING RATE:
 5/5
 For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: pr pic

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: The log

Comment 5

[xiaokang.chen]

Dear Rudy,
How do you think about this? Thanks.

Comment 6

[hyuna.cho]

Due to the path of Bug 871437, it's happened.

Need to adjust the below also

function getThreshold(value) in battery_manager.js

if (value != -1 && battery.level > value && _powerSaveEnabled) {

Comment 7

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Rudy, if you don't have time to check this bug, I can take it -- just assign it to me. Thanks!

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

We should define the expected behavior at first.

The function is "turn on automatically", so that I think power saving mode should not be "turned off automatically" no matter what value users set. The expected behavior would be, if the current battery level is 14% and the power saving mode is disabled:

1. Click Turn on automatically
2. Click 15% battery left
3. Power saving mode is enabled automatically
4. Click Turn on automatically
5. Click 5% battery left or never
6. Power saving mode is still enabled

Comments?

Comment 9

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Arthur Chen [:arthurcc] from comment #8)
> We should define the expected behavior at first.
> 
> The function is "turn on automatically", so that I think power saving mode
> should not be "turned off automatically" no matter what value users set. The
> expected behavior would be, if the current battery level is 14% and the
> power saving mode is disabled:
> 
> 1. Click Turn on automatically
> 2. Click 15% battery left
> 3. Power saving mode is enabled automatically
> 4. Click Turn on automatically
> 5. Click 5% battery left or never
> 6. Power saving mode is still enabled
> 
> Comments?

Hey Arthur, from my understanding the power saving mode should be turned off if the user selects a threshold less than the current available battery charge (e.g. 14% charge, power saving on -> select 5% threshold -> power saving should be turned off).

This behavior is quite important since the power saving mode disables Wi-Fi, Data, Bluetooth, and Geolocation, thus significantly limiting the functions of the phone. If the user updates the mode to a lower threshold, all those (previously enabled) services should be restored.

Comment 10

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #11077 - Disable power saving mode when 'never' selected

If the power saving mode was previously enabled and the user switches the "turn on automatically" threshold to "never", the mode should be disabled, thus ensuring that the functions previously disabled (i.e. Wi-Fi, Data, Geolocation, Bluetooth) are enabled again.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 778708 [details]
Pull Request #11077 - Disable power saving mode when 'never' selected

Makes sense.

Comment 12

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks Alive! Landed on master:
https://github.com/mozilla-b2g/gaia/commit/760884db3f08ba9e8f05fe101e121ee8876d8adc

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 760884db3f08ba9e8f05fe101e121ee8876d8adc to:
v1-train: 8d515fcee27a48c2149278092bd6a95b5ac512f2

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 8d515fcee27a48c2149278092bd6a95b5ac512f2

Comment 15

[mdaniloff]

Verified.. If the power saving mode was previously enabled and the user switches the "turn on automatically" threshold to "never", the mode is disabled 

Environmental Variables
Build ID: 20130729070226
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8135299f3efd
Gaia: 7aaffc8ccb6cf7ddd1e97943c108f1cb9eae5de0
Platform Version: 18.1

Comment 16

[Bingqing Li]

I can still reproduce this bug on v1.2 and v1.3

Environments:
----------------------------
v1.3
Gaia      01e9da49be2cc4bc134eeefc434740d572ec2246
Gecko     http://hg.mozilla.org/releases/mozilla-aurora/rev/af28fe58e263
BuildID   20131224004001
Version   28.0a2

v1.2
Gaia      724d36716bcbbc5cee1af18b94cc328c289d0ccc
Gecko     http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/931864adcf68
BuildID   20131224004001
Version   26.0

Comment 17

[Bingqing Li]

(In reply to Bingqing Li from comment #16)
> I can still reproduce this bug on v1.2 and v1.3
> 
If the power saving mode was previously enabled and the user switches the "turn on automatically" threshold to "never", the mode is still enabled.(At least, the status of the button is enabled.)