894388 - B2G desktop throws error on lock screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

Cannot unlock system due to this unless you go the FTU route.

Timestamp: 7/16/13 4:10:08 PM
Error: TypeError: actors is null
Source File: app://costcontrol.gaiamobile.org/shared/js/icc_helper.js
Line: 80

Timestamp: 7/16/13 4:10:08 PM
Error: TypeError: connection is undefined
Source File: app://costcontrol.gaiamobile.org/js/config/config_manager.js
Line: 100

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Remove the errors

This removes the errors but still cannot unlock...

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

The lockscreen not unlocking is due to https://github.com/mozilla-b2g/gaia/commit/ea706961115f996b2bf68cb1d83a0b703e728900, because we don't do mouse -> touch conversion in B2G Desktop this one won't unlock anymore. That's gonna bite us.

Comment 3

[Kevin Grandon :kgrandon]

Sorry, that was the wrong bug. Bug 891882 captures the fact that the lockscreen is not unlocking. I believe this to be because we're not shipping our touch support extension with the profile, and we should be.

I believe if you generate your own profile it should work.

I think we should close this out as, bug 891882 will cover Fixing B2G desktop touch support.

If we're not seeing these errors in nightly, then it's because we're not mocking this properly in B2G desktop, and we probably should.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch that fixes errors on startup regarding mozMobileConnection

The unlocking of the device is covered by the bug referenced by Kevin Grandon, this patch fixes a bunch of javascript errors that pop up during B2G desktop startup.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 776957 [details] [review]
Patch that fixes errors on startup regarding mozMobileConnection

Thanks!!

Given the fact the patch also touches Usage app, I think Salva should look into it.

Comment 6

[Salvador de la Puente González [:salva]]

Comment on attachment 776957 [details] [review]
Patch that fixes errors on startup regarding mozMobileConnection

Please attend comments on GitHub before merging.
Thank you for the patch.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Thanks, addressed comments and landed in https://github.com/mozilla-b2g/gaia/commit/b2b399165362a8690fe422a1669602b1ac2596e2