89452 - Insert Table Row in multi row/col table inserts row with text

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[sujay]

using 7/5 build of netscape:

1) launch netscape
2) launch composer
3) insert 2 x 2 table
4) populate each cell with text
5) click in a cell in top row
6) Table Insert | Row Below

notice the row gets added, but that row has text in it!

it should be blank.

WORKAROUND = minimize window and then maximize window

then you have a blank/empty row

this is a repaint/layout issue

Comment 1

[rubydoo123]

if it's repaint, then it goes to kevin or marc

Comment 2

[sujay]

can we get a target milestone? thanks.

Comment 3

[sujay]

can we get a target milestone? thanks.

Comment 4

[Marc Attinasi]

Well, we can try for 0.9.3 - I wonder if the recent fix (on the trunk) for bug
86852 fixes this? The fix was to correct an optimization that made too small of
an area invalidate when the content was changed. Sujay, can you check it out on
a new trunk build? Thanks.

Comment 5

[sujay]

Marc, I just downloaded 7/10 trunk build.

same problem..

it adds a new Row Below, but it has text in it.
only after you force a repaint(minimize followed by maximize),
then the Row have blank cells.

Comment 6

[rubydoo123]

*** Bug 91220 has been marked as a duplicate of this bug. ***

Comment 7

[Ariel Gonzalez]

Still seeing this using 2001-07-20-03 under Win2k-sp1. It is only a redraw
problem, or so it seems. I can't "edit" the text in the new row, because its not
really there. If you save right after adding the row, it saves without any text.

Quick fix could just be to force a redraw after every table configuration change
(insert or delete AND row or column) since there is no data loss, just an annoyance.

Comment 8

[Marc Attinasi]

I think I was suppossed to send this to karnaze last week. Over to Chris now. If
you want me to check this in block-land, jsut send it back, but it sounds like a
table-specific problem.

Comment 9

[Marc Attinasi]

ok, really reassigning this time

Comment 10

[Jaime Rodriguez, Jr.]

Nominating . . .

Comment 11

[Blake Ross]

Missed 0.9.3.

Comment 12

[karnaze (gone)]

Attachment: patch to fix the bug

Comment 13

[Marc Attinasi]

Couple of comments on the patch:

1) if you use an nsAutoVoidArray instead of an nsVoidArray you might save on
some mallocs. I'm not sure how many rows you will be putting in there, but it
might be worth checking out

2) You should assert (or check) rgFrame before you deref (in case the ElementAt
returns you null).

3) After you do the invalidation, don't you want to break out of the loops and
stop searching the rows and rowgroups?

Consider / answer these potential issues, and [s]r=attinasi

Comment 14

[Nathan]

I believe bug 88976 is a dupe of this

bug 91491 "layout does not refresh correctly after table caption insert" seems
to me like it might possibly be related

Comment 15

[Alexandru Savulov]

r=alexsavulov

Comment 16

[karnaze (gone)]

Attachment: revised patch to include most of attinasi's suggestions plus reset row inserted bit.

Comment 17

[karnaze (gone)]

The patch is in.

Comment 18

[wkfx2003-bugzilla]

*** Bug 88976 has been marked as a duplicate of this bug. ***

Comment 19

[sujay]

verified in 8/17 build.