894563 - App is left with an empty (undeletable) en-US localisation, which doesn't inherit the privacy policy.

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P3)

Description

[Andrew Williamson [:eviljeff]]

This is app has a default locale of es, and a privacy policy (and description, etc) in Spanish.  It also has an empty en-US localisation.  This wouldn't be a huge problem if it wasn't that the privacy policy isn't correctly inheriting from the Spanish default so it appears empty if you access the listing in English.  It's also undeletable so the listing can't be trivially fixed.

Comment 1

[Mathieu Pillard [:mat]]

Andrew mentioned on IRC this also affects https://marketplace.firefox.com/app/gomoku/

In both cases, the apps have a default_locale set to something other than en-US ("es" for audioteka-1, "pl" for gomoku), and we created an empty translation in en-US for their privacy policy.

Comment 2

[Mathieu Pillard [:mat]]

This didn't affect description because it's pulled from the manifest - it only affects fields which have empty values initially, such as privacy policy, homepage and support url.

Comment 3

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/248e998c5eeb8159b5bdb2864a6ca74ee359f9d1

Note: This bug is about preventing empty translations to be created automatically in the first place. Being able to delete translations, empty or not, is tracked in bug 896466.


STR:
- On -dev, with the site in english, upload an app with a default_locale of "es".
- Verify that the Privacy Policy you entered correctly shows up in the edit listing page when selecting "Localizing for" in Spanish. It should also show up as the fallback when you select English.

Comment 4

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/developers/ on FF25 (Win 7).
Postfix screencast http://screencast.com/t/YOy1zjoFzmz
Closing bug.