894606 - Build bustage after bug 870406

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Daniel Holbert [:dholbert]]

I'm hitting build bustage in widget/gtk2 after bug 888863's patch landed.

Here's a snippet of my build output, from a clobber mozilla-inbound build:
{
/mozilla-inbound/widget/gtk2/gtk3drawing.c:75:1: error: unknown type name 'GtkStateFlags'
 GetStateFlagsFromGtkWidgetState(GtkWidgetState* state)
 ^
/mozilla-inbound/widget/gtk2/gtk3drawing.c: In function 'GetStateFlagsFromGtkWidgetState':
/mozilla-inbound/widget/gtk2/gtk3drawing.c:77:5: error: unknown type name 'GtkStateFlags'
     GtkStateFlags stateFlags = GTK_STATE_FLAG_NORMAL;
     ^
/mozilla-inbound/widget/gtk2/gtk3drawing.c:77:32: error: 'GTK_STATE_FLAG_NORMAL' undeclared (first use in this function)
     GtkStateFlags stateFlags = GTK_STATE_FLAG_NORMAL;
                                ^
/mozilla-inbound/widget/gtk2/gtk3drawing.c:77:32: note: each undeclared identifier is reported only once for each function it appears in
/mozilla-inbound/widget/gtk2/gtk3drawing.c:80:22: error: 'GTK_STATE_FLAG_INSENSITIVE' undeclared (first use in this function)
         stateFlags = GTK_STATE_FLAG_INSENSITIVE;
                      ^
/mozilla-inbound/widget/gtk2/gtk3drawing.c:83:27: error: 'GTK_STATE_FLAG_ACTIVE' undeclared (first use in this function)
             stateFlags |= GTK_STATE_FLAG_ACTIVE;
                           ^
/mozilla-inbound/widget/gtk2/gtk3drawing.c:85:27: error: 'GTK_STATE_FLAG_PRELIGHT' undeclared (first use in this function)
             stateFlags |= GTK_STATE_FLAG_PRELIGHT;
                           ^
/mozilla-inbound/widget/gtk2/gtk3drawing.c:87:27: error: 'GTK_STATE_FLAG_FOCUSED' undeclared (first use in this function)
             stateFlags |= GTK_STATE_FLAG_FOCUSED;
                           ^
/mozilla-inbound/widget/gtk2/gtk3drawing.c: In function 'moz_gtk_button_paint':
/mozilla-inbound/widget/gtk2/gtk3drawing.c:872:5: error: unknown type name 'GtkStateFlags'
     GtkStateFlags state_flags = GetStateFlagsFromGtkWidgetState(state);
     ^
/mozilla-inbound/widget/gtk2/gtk3drawing.c:873:5: error: unknown type name 'GtkStyleContext'
     GtkStyleContext* style = gtk_widget_get_style_context(widget);    
     ^
/mozilla-inbound/widget/gtk2/gtk3drawing.c:873:5: warning: implicit declaration of function 'gtk_widget_get_style_context' [-Wimplicit-function-declaration]
/mozilla-inbound/widget/gtk2/gtk3drawing.c:873:30: warning: initialization makes pointer from integer without a cast [enabled by default]
     GtkStyleContext* style = gtk_widget_get_style_context(widget);    
                              ^
}

I'll post the full log as an attachment.

stransky/karl, any idea what's going on?  Am I missing a library, maybe? (I do have "libgtk-3-dev" already installed.)

I'm on Ubuntu 13.04 64-bit.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: full log of build errors

Here's the full log of the build errors I get, when compiling in widget/gtk2.

Comment 2

[Daniel Holbert [:dholbert]]

(I haven't 100% verified that bug 888863 caused this; I'm just going off of "who touched gtk3drawing.c last".)

Comment 3

[Daniel Holbert [:dholbert]]

Yup, looks like I was just unlucky enough to hit build bustage from bug 870406, actually -- this wasn't caused by bug 888863 after all.

RyanVM just backed out bug 870406, so this should now be FIXED by backout.