888863 - Port GTK2 to GTK3 - entry combo box update

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

+++ This bug was initially created as a clone of Bug #627699 +++

GTK+ 3.0 and GNOME 3 are approaching and we should get Firefox ready for them. This one is about combo box rendering.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: added combo box entry widget

Rather minor fix but we may do it, fixes a TODO we left here.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

The original purpose of this bug was incorrect combo box rendering, but it was caused by missing linux theme on my working tree. The comboboxes are rendered correctly in latest trunk, so let's address the TODO here at least.

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 770124 [details] [diff] [review]
added combo box entry widget

>-        if (GTK_IS_HBOX(buttonChild)) {
>+        if (GTK_IS_BOX(buttonChild)) {
>             /* appears-as-list = FALSE, cell-view = TRUE; the button
>              * contains an hbox. This hbox is there because ComboBoxEntry
>              * inherits from ComboBox which needs to place a cell renderer,
>              * a separator, and an arrow in the button when appears-as-list
>              * is FALSE. Here the hbox should only contain an arrow, since
>              * a ComboBoxEntry doesn't need all those widgets in the
>              * button. */
>             gtk_container_forall(GTK_CONTAINER(buttonChild),

I think this change is needed in ensure_combo_box_widgets() also.

The comment could do with some updating as ComboBoxEntry doesn't exist in GTK3.
I suggest copying the comment from ensure_combo_box_widgets(), and changing "hbox"s to "box"s.
I don't think the "should only contain an arrow" bit is or was true.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch for check-in

An updated patch for check-in.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d889929c408

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d889929c408