894715 - Defect - URLs selected by touch are copied from the urlbar with trimming

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: App Bar, defect)

Description

[Jonathan Wilde [:jwilde]]

Steps to reproduce:
- Go to a page
- Swipe up to reveal the navbar
- Tap on the text to select it
- Long press to reveal the context menu
- Tap "copy"

...

- Paste somewhere else

Expected result:
Pasted text should be the entire, untrimmed URL.

Actual result:
Pasted text is the trimmed URL.

Comment 1

[Jonathan Wilde [:jwilde]]

Attachment: failing testcase

Comment 2

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 784734 [details] [diff] [review]
failing testcase

Review of attachment 784734 [details] [diff] [review]:
-----------------------------------------------------------------

Correctly (currently) fails. Looks good.

Comment 3

[Jonathan Wilde [:jwilde]]

Attachment: patch v0

As far as I can tell, this doesn't break anything.

Comment 4

[Jim Mathies [:jimm]]

(In reply to Jonathan Wilde [:jwilde] from comment #3)
> Created attachment 788035 [details] [diff] [review]
> patch v0
> 
> As far as I can tell, this doesn't break anything.

What the heck are you still doing up at this hour? :)

Comment 5

[Allison Naaktgeboren :ally]

Comment on attachment 788035 [details] [diff] [review]
patch v0

Review of attachment 788035 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for reducing the number of code paths while fixing the issue. Also for abiding by the metro style guide.

I know you've run the tests locally, but please doublecheck on try before landing. 

Please file a followup for more tests.

Comment 6

[Jonathan Wilde [:jwilde]]

Followup is bug 903677, try run is at:
https://tbpl.mozilla.org/?tree=Try&rev=bf5546db8b66

Comment 7

[Jonathan Wilde [:jwilde]]

https://hg.mozilla.org/integration/fx-team/rev/141402d84ef5
https://hg.mozilla.org/integration/fx-team/rev/6ad5e7c6ecf2

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/141402d84ef5
https://hg.mozilla.org/mozilla-central/rev/6ad5e7c6ecf2