If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Defect - URLs selected by touch are copied from the urlbar with trimming

RESOLVED FIXED in Firefox 26

Status

Firefox for Metro
App Bar
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jwilde, Assigned: jwilde)

Tracking

unspecified
Firefox 26
x86_64
Windows 8
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [preview])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Steps to reproduce:
- Go to a page
- Swipe up to reveal the navbar
- Tap on the text to select it
- Long press to reveal the context menu
- Tap "copy"

...

- Paste somewhere else

Expected result:
Pasted text should be the entire, untrimmed URL.

Actual result:
Pasted text is the trimmed URL.
(Assignee)

Updated

4 years ago
Assignee: nobody → jwilde
Status: NEW → ASSIGNED
Whiteboard: [preview]
(Assignee)

Comment 1

4 years ago
Created attachment 784734 [details] [diff] [review]
failing testcase
(Assignee)

Updated

4 years ago
Attachment #784734 - Flags: review?(sfoster)
Comment on attachment 784734 [details] [diff] [review]
failing testcase

Review of attachment 784734 [details] [diff] [review]:
-----------------------------------------------------------------

Correctly (currently) fails. Looks good.
Attachment #784734 - Flags: review?(sfoster) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 788035 [details] [diff] [review]
patch v0

As far as I can tell, this doesn't break anything.
Attachment #788035 - Flags: review?(jmathies)

Comment 4

4 years ago
(In reply to Jonathan Wilde [:jwilde] from comment #3)
> Created attachment 788035 [details] [diff] [review]
> patch v0
> 
> As far as I can tell, this doesn't break anything.

What the heck are you still doing up at this hour? :)
Comment on attachment 788035 [details] [diff] [review]
patch v0

Review of attachment 788035 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for reducing the number of code paths while fixing the issue. Also for abiding by the metro style guide.

I know you've run the tests locally, but please doublecheck on try before landing. 

Please file a followup for more tests.
Attachment #788035 - Flags: review?(jmathies) → review+
(Assignee)

Updated

4 years ago
Blocks: 903677
(Assignee)

Comment 6

4 years ago
Followup is bug 903677, try run is at:
https://tbpl.mozilla.org/?tree=Try&rev=bf5546db8b66
(Assignee)

Comment 7

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/141402d84ef5
https://hg.mozilla.org/integration/fx-team/rev/6ad5e7c6ecf2
Whiteboard: [preview] → [preview][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/141402d84ef5
https://hg.mozilla.org/mozilla-central/rev/6ad5e7c6ecf2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [preview][fixed-in-fx-team] → [preview]
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.