Closed Bug 894878 Opened 7 years ago Closed 7 years ago

CSV output template for request queues has gone away

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: gerv, Assigned: dkl)

Details

Attachments

(1 file)

gerv@mink:/usr/src$ ls -l bmo-4.0/template/en/default/request/queue.csv.tmpl 
-rw-r----- 1 gerv www-data 2056 May 10  2012 bmo-4.0/template/en/default/request/queue.csv.tmpl
gerv@mink:/usr/src$ ls -l bmo-4.2/template/en/default/request/queue.csv.tmpl 
ls: cannot access bmo-4.2/template/en/default/request/queue.csv.tmpl: No such file or directory
gerv@mink:/usr/src$ 

This template was added to Bugzilla trunk in bug 413851 on 2nd January 2013, and has been deployed on BMO since at least December 16th 2011, because I wget the CSV request list once per day and I have daily data from it.

Between March 5th and March 6th 2013 I stopped getting CSV, and started getting HTML. The template seems not to be in the bmo-4.2 repo.

What happened?

Gerv
looks like it was accidentally skipped when bringing across bmo customisations to the 4.2 branch.  we upgraded to 4.2 on the 6th march, which explains that timing.

sorry about that :( thankfully the fix is easy:

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
added template/en/default/request/queue.csv.tmpl
Committed revision 8877.
Assignee: nobody → glob
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Great :-) Thanks. How can we avoid this happening again, to this or another template? Is there some process you followed which needs a step added, or something?

Gerv
(In reply to Gervase Markham [:gerv] from comment #2)
> Great :-) Thanks. How can we avoid this happening again, to this or another
> template? Is there some process you followed which needs a step added, or
> something?

i was a simple oversight during the massive work of porting bmo changes to a new branch.  there isn't much we can do process-wise to avoid this sort of mistake reoccurring.
OK. Here endeth the 5 whys :-)

Gerv
This still doesn't work. You need to apply all of the patch on bug 413851, including the patch to request.cgi to enable ctype support.

Gerv
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch 894878_1.patchSplinter Review
Sigh. Yeah most of that patch is missing from bmo/4.2 for whatever reason. Here is the rest.

dkl
Assignee: glob → dkl
Status: REOPENED → ASSIGNED
Attachment #784545 - Flags: review?(glob)
Comment on attachment 784545 [details] [diff] [review]
894878_1.patch

Review of attachment 784545 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob by inspection only

address issues before committing.

::: buglist.cgi
@@ +327,2 @@
>      }
> +        else {

nit: indentation

::: request.cgi
@@ +48,5 @@
>  my $action = $cgi->param('action') || '';
> +my $format = $template->get_format('request/queue',
> +                                   scalar($cgi->param('format')),
> +                                   scalar($cgi->param('ctype')));
> +use Data::Dumper; print STDERR Dumper $format;

remove debugging
Attachment #784545 - Flags: review?(glob) → review+
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2
modified buglist.cgi
modified report.cgi
modified request.cgi
modified Bugzilla/CGI.pm
modified template/en/default/request/queue.html.tmpl                                                                         Committed revision 8933.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.