895094 - Fix browser.js ReferenceError: "reference to undefined property data.inputs"

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-inputs-ReferenceError.patch

E/GeckoConsole(18112): [JavaScript Warning: "ReferenceError: reference to undefined property (intermediate value).inputs" {file: "chrome://browser/content/browser.js" line: 1649}]

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 777348 [details] [diff] [review]
fix-inputs-ReferenceError.patch

Review of attachment 777348 [details] [diff] [review]:
-----------------------------------------------------------------

I don't understand how this is any different, or why you're getting this error. Can you give me STR?

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 777348 [details] [diff] [review]
fix-inputs-ReferenceError.patch

r?

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 777348 [details] [diff] [review]
fix-inputs-ReferenceError.patch

Review of attachment 777348 [details] [diff] [review]:
-----------------------------------------------------------------

See my comment above.

Comment 4

[Chris Peterson [:cpeterson]]

oops! Sorry about the double post. I was looking at a stale version of this bug and missed your earlier comments. <:)

STR:
1. Open Fennec's settings and "Clear Private Data"
2. Open http://maps.google.com
3. Watch logcat
4. Fennec will show two doorhangers.
5. When you dismiss one (it doesn't matter which, top or bottom doorhanger), logcat reports the following JS error:

E/GeckoConsole(16156): [JavaScript Warning: "ReferenceError: reference to undefined property (intermediate value).inputs" {file: "chrome://browser/content/browser.js" line: 1738}]

6. When you dismiss the second doorhanger, there is no JS error.

Comment 5

[Chris Peterson [:cpeterson]]

Wes, here are the STR.

Comment 6

[Wesley Johnston (:wesj)]

I can't reproduce this. Maybe its device dependent?

I've asked around a bit, and no one (including me) seems to have any idea why this patch would do anything at all.

Comment 7

[Chris Peterson [:cpeterson]]

Strange. I'm no longer able to reproduce this error message either. :\