Enable system messages on Android

RESOLVED INCOMPLETE

Status

()

defect
RESOLVED INCOMPLETE
6 years ago
2 years ago

People

(Reporter: cpeterson, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

6 years ago
No description provided.
Reporter

Comment 1

6 years ago
Posted patch WIP-android-sysmsg.patch (obsolete) — Splinter Review
Nikhil: this is a WIP patch from the changes we made on Monday plus some other fixes to get system messages partially working.
Attachment #778229 - Flags: feedback?(nsm.nikhil)
Reporter

Updated

6 years ago
Component: DOM → DOM: Device Interfaces
Reporter

Updated

6 years ago
Depends on: 895104
Reporter

Comment 2

6 years ago
WIP v2 removed some debug code. I still haven't figured out why the first message is delivered but subsequent messages are queued and never delivered.
Attachment #778229 - Attachment is obsolete: true
Attachment #778229 - Flags: feedback?(nsm.nikhil)
Attachment #778696 - Flags: feedback?(nsm.nikhil)
Last I spoke with Jonas, we said that we could likely deprecate System Messages in favour of Event Pages. Do we really want to implement this in Firefox Android if our plan is to deprecate the API?
Flags: needinfo?(jonas)
Wouldn't event pages receive system messages? Or is there to be an alternate API for them to receive messages?
Comment on attachment 778696 [details] [diff] [review]
WIP-android-sysmsg-v2.patch

Review of attachment 778696 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks good to me. The 'subsequent messages not delivered' bug occurs on Fx Desktop too. I think I'll have to refresh my patches to work with the changes made.
Attachment #778696 - Flags: feedback?(nsm.nikhil) → feedback+
(In reply to Nikhil Marathe [:nsm] from comment #5)
> Comment on attachment 778696 [details] [diff] [review]
> WIP-android-sysmsg-v2.patch
> 
> Review of attachment 778696 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The patch looks good to me. The 'subsequent messages not delivered' bug
> occurs on Fx Desktop too. I think I'll have to refresh my patches to work
> with the changes made.

We could easily wake any event registered by a Web Page behaving like a system message. We would not need any extra API to make that happen I believe.
I definitely think that the syntax for system messages will change. But given that I think that system messages are essentially part of the app runtime, which are already are working on for Android, I think it's ok to also do support for system messages too.

For now I think we should use the exact same syntax and functionality as we use for Firefox OS. So no background workers.

But in general, it might be good to have a conversation on dev-platform about how we should do apps on Android and Desktop given that we're aiming to not do prefixed APIs, and not do mozilla specific APIs other than on only nightly and aurora.
Flags: needinfo?(jonas)
More mass-incompleting of FxOS bugs in the Device Interfaces component.

Please update and let me know if any of these are still valid.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.