895237 - [STK] dummy function problem in icc.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Leo]

Attachment: log file1

VIVO operator is testing for STK by using special sim card. It is called "HRS test".
But there is critical problem. 
this sim card send toolkit cmd(SET_UP_MENU -> PROVIDE_LOCAL_INFO) after booting. 

As you know, when UE receive unsol proactive cmd, icc_worker will handle about that. 
So, PROVIDE_LOCAL_INFO will be processed in icc_work.js. 
When we have finished analyzing this issue, We think that dummy function is not operated properly. 
plz see this problem and let me know why this log printed "iccmanager is not defined" 

<radio.log>
07-17 16:35:01.699 E/GeckoConsole(  152): [JavaScript Error: "iccManager is not defined" {file: "app://system.gaiamobile.org/js/icc_worker.js" line: 9}]
07-17 16:35:01.699 E/GeckoConsole(  152): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "iccManager is not defined" {file: "app://system.gaiamobile.org/js/icc_worker.js" line: 9}]' when calling method: [nsIDOMSystemMessageCallback::handleMessage]" {file: "jar:file:///system/b2g/omni.ja!/components/SystemMessageManager.js" line: 97}]

<icc_worker.js>
dummy: function icc_worker_dummy() {
    DUMP('STK Command not implemented yet');
    iccManager.responseSTKCommand({
      resultCode: iccManager._icc.STK_RESULT_OK
    });
  },

........

'0x26': function STK_CMD_PROVIDE_LOCAL_INFO(command, iccManager) {
    // https://bugzilla.mozilla.org/show_bug.cgi?id=817952
    DUMP('STK_CMD_PROVIDE_LOCAL_INFO', command.options);
    icc_worker.dummy();
  },
 

DESCRIPTION:
Insert a new VIVO Sim Card (HLR:18) and turn on the UE.
Wait until UE show HRS Activation Menu.

EXPECTED:
UE should show HRS pop-up.

ACTUAL:
UE rings the notification but no pop-up is showed. UE shows SMS Menu. If user returns to Idle Screen and open SMS Menu, the pop-up is showed.

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Fixed ICC Dummy method

Comment 2

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/gaia/commit/9e5a606d86605f6cb7f61ae307df4e6f33a83d4f

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 9e5a606d86605f6cb7f61ae307df4e6f33a83d4f to:
v1-train: f9239c975a5e45f1ae9eaec64ee9e92e8b3f73e7

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: f9239c975a5e45f1ae9eaec64ee9e92e8b3f73e7